From owner-freebsd-multimedia@FreeBSD.ORG Mon Jun 7 08:53:28 2010 Return-Path: Delivered-To: multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0549A1065677 for ; Mon, 7 Jun 2010 08:53:28 +0000 (UTC) (envelope-from avg@pautina.in.ua) Received: from smtp.pautina-nau.net (smtp.pautina-nau.net [194.0.89.243]) by mx1.freebsd.org (Postfix) with ESMTP id B4D688FC22 for ; Mon, 7 Jun 2010 08:53:27 +0000 (UTC) Received: from [92.249.64.71] (helo=trant.local.) by smtp.pautina-nau.net with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1OLXpA-0001AK-Mc; Mon, 07 Jun 2010 11:36:48 +0300 Received: from trant.local. (localhost [127.0.0.1]) by trant.local. (8.14.4/8.14.4) with ESMTP id o578amIP069749; Mon, 7 Jun 2010 11:36:48 +0300 (EEST) (envelope-from avg@trant.local) Received: (from root@localhost) by trant.local. (8.14.4/8.14.4/Submit) id o578amrC069748; Mon, 7 Jun 2010 11:36:48 +0300 (EEST) (envelope-from avg) Date: Mon, 7 Jun 2010 11:36:48 +0300 (EEST) Message-Id: <201006070836.o578amrC069748@trant.local.> To: FreeBSD-gnats-submit@freebsd.org From: Andriy Gapon X-send-pr-version: 3.113 X-GNATS-Notify: X-Remote-Sender-IP: 92.249.64.71 X-Remote-Sender-User: unknown Cc: multimedia@freebsd.org Subject: [PATCH] multimedia/mkvtoolnix: use += for setting CPPFLAGS and LDFLAGS X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2010 08:53:28 -0000 >Submitter-Id: current-users >Originator: Andriy Gapon >Organization: >Confidential: no >Synopsis: [PATCH] multimedia/mkvtoolnix: use += for setting CPPFLAGS and LDFLAGS >Severity: non-critical >Priority: low >Category: ports >Class: change-request >Release: FreeBSD 9.0-CURRENT amd64 >Environment: >Description: Right now this port simply sets CPPFLAGS and LDFLAGS thus overriding any local tuning that a user might want to do via e.g. /etc/make.conf. I think that in general it is recommended that CPPFLAGS, LDFLAGS, etc are amended, not overridden, in ports Makefiles. Port maintainer (multimedia@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99 >How-To-Repeat: >Fix: --- mkvtoolnix-3.3.0_2.patch begins here --- diff -ruN --exclude=CVS /usr/ports/multimedia/mkvtoolnix.orig/Makefile /usr/ports/multimedia/mkvtoolnix/Makefile --- /usr/ports/multimedia/mkvtoolnix.orig/Makefile 2010-06-06 23:43:58.000000000 +0300 +++ /usr/ports/multimedia/mkvtoolnix/Makefile 2010-06-07 11:33:29.069800315 +0300 @@ -28,8 +28,8 @@ USE_GMAKE= yes USE_ICONV= yes GNU_CONFIGURE= yes -CPPFLAGS= -I${LOCALBASE}/include -LDFLAGS= -L${LOCALBASE}/lib +CPPFLAGS+= -I${LOCALBASE}/include +LDFLAGS+= -L${LOCALBASE}/lib CONFIGURE_ENV= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}" \ ac_cv_path_PO4A=no CONFIGURE_ARGS= --enable-lzo --enable-bz2 --disable-qt \ --- mkvtoolnix-3.3.0_2.patch ends here ---