From nobody Wed Jun 11 09:34:38 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bHL8t6jg8z6018f; Wed, 11 Jun 2025 09:34:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bHL8t5KBmz44Fw; Wed, 11 Jun 2025 09:34:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749634478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iErWxVzvEt4hVg8WG68DjFiIiuUd6Q4U/szV51dSk50=; b=e85kw77GntHpLhr/b7xH4ODVcU5v5HZ3Rw2Lj1ZU53LFFYt6I6PwalbDSCL0cs95PusaE9 1F6dU2iNE2u/ICChlqBYa2IS/Zn1ImhVvdY0yDg3t2AWX/IhSODNYppiA80saeNgMEw0XN 4pcQdBbV+EEfQZxI/ndM/Naa21XTPcWlRQRsrBK6S0oF2dlZZl+mmT2lbydYPYFsDXhqE/ u4TYGKGIE3cOfod0y+///tLzClEHIeu8WstBOrAPJdMD8+jKax7Wgw4BA0ELXznPvjqZd7 NjRFv+RlBwDZgHQOeFmImHyAYV1IR9xI25szLZCfWSuW6k1OXs/GrzzY87nYig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749634478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iErWxVzvEt4hVg8WG68DjFiIiuUd6Q4U/szV51dSk50=; b=A25XnBfR+RKRPLrdMAcVcVCmahzV1ur4XF+GZ+h139zWgm1Sf+S6qYYzUiJXwMWCoq7TEe Q5DvvjBFgPrl+dNh7lm8ztjG9er1nLQitLOHnzuwI1159ACR7gTxNmEnPBifjn0+4c9D4T RNudBNsq8wtOXmwqxDzpMREFuSpghhF1wJNb8EY2Sz1As//kMWa5UJBfjzpGMgB2hEqX/O rbMMYiUgoF3o0aA3HNWeWmLPwaDlzuvlerzXM9F3nNEQCYucYSk8w0OligwLC6LvrXjJA4 sfONUQPSi3UJ+TL4awqQGhcEQSQJz0cbx5/610/3AD8z/Me7cXCSfaxBmo4bRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749634478; a=rsa-sha256; cv=none; b=PaUjBQsGW7SHqZZPf1Ok9UHdalvZQhee96sVNOvAb2QI2uhhN3ss7/uKYqCghYG8YlwwJw I/CSuemn9nfa9Vc4K3+AtZAuNsEEaIWdxubtE2F9Kyr5qfiZ93/TMK0Nbb0TO1wo+VulBv LPoobEevULd17g2LYxcDuk9EveTxV/Xn9/9BHjTsFiCNUewK4K1cylD928Dc4ZNMRaRytb 8VR3F8aAnivHq2+mW6ROViGAutS6rOrE1ch8kW21a+4BFdMKgQ1w2hAfZFiuQjBiUbY8Fn d40svRDyISLQ15jmwpDIVsBCpwqTGgOofIrn9X6SdpWNwb8JDJMD+WdkO5LNeg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bHL8t4qJcz5cs; Wed, 11 Jun 2025 09:34:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55B9YcPZ000922; Wed, 11 Jun 2025 09:34:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55B9YcAx000919; Wed, 11 Jun 2025 09:34:38 GMT (envelope-from git) Date: Wed, 11 Jun 2025 09:34:38 GMT Message-Id: <202506110934.55B9YcAx000919@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Turner Subject: git: d41a2ba73cbe - main - scmi: Avoid a use-after-free List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d41a2ba73cbe4ed9f3d3de5c4755fb5db6b80847 Auto-Submitted: auto-generated The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=d41a2ba73cbe4ed9f3d3de5c4755fb5db6b80847 commit d41a2ba73cbe4ed9f3d3de5c4755fb5db6b80847 Author: Andrew Turner AuthorDate: 2025-06-09 22:30:36 +0000 Commit: Andrew Turner CommitDate: 2025-06-09 22:32:11 +0000 scmi: Avoid a use-after-free Use LIST_FOREACH_SAFE to avoid a use-after-free in scmi_reqs_pool_free. The next pointer will be invalid after the call to free meaning LIST_FOREACH will dereference a freed struct to move to the next item. Reviewed by: emaste Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D50753 --- sys/dev/firmware/arm/scmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/firmware/arm/scmi.c b/sys/dev/firmware/arm/scmi.c index b27f7211201e..6f16b58f49bf 100644 --- a/sys/dev/firmware/arm/scmi.c +++ b/sys/dev/firmware/arm/scmi.c @@ -291,9 +291,9 @@ scmi_reqs_pool_allocate(device_t dev, const int max_msg, const int max_payld_sz) static void scmi_reqs_pool_free(struct scmi_reqs_pool *rp) { - struct scmi_req *req; + struct scmi_req *req, *tmp; - LIST_FOREACH(req, &rp->head, next) { + LIST_FOREACH_SAFE(req, &rp->head, next, tmp) { mtx_destroy(&req->mtx); free(req, M_DEVBUF); }