From owner-dev-commits-src-main@freebsd.org Mon Apr 12 14:36:36 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5E4925D371B; Mon, 12 Apr 2021 14:36:36 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FJrsH6WPTz4Y8p; Mon, 12 Apr 2021 14:36:35 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x72e.google.com with SMTP id c123so9026595qke.1; Mon, 12 Apr 2021 07:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pBXd7BmkC3jicI9CWK0tI5D+7JK9refNL/nsY0cZi2M=; b=vSlegaSCA/IFZc0UD/Cn08ttyWPrleOEyXRzG+QwHxiy0L5oCHTNXuW0msmTK+pY+V dntTWuIRZ1DmMO8m1uY8NaTGU2CM85wy5TsorOlsEiNIZxAeptkgRfdGEwnJER7BKAyr wrg7qVFrEMOtU8ZDmOsaM1mAAAnRb/Y1IRdVG8xD42OojxaqoDnfuWJLcMgV0PtQ3fWJ h3747zxXRtXlHkOeQvhSoxbLVo3PweJ6tJLt8a3Waaa2RY1DRAMjmvxjTmwctjwoz/7z 0uMjiTtcNWAwjZGaI3qVwVUD1dPd20YoH40zxc8FzE00fA1P0dFCSoGQyQDMedfzbx4l eFqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=pBXd7BmkC3jicI9CWK0tI5D+7JK9refNL/nsY0cZi2M=; b=DoomRP5mJZNySPP+QpteNTu/LY4LOY3EovXCktgFaH96h3WnHpzgNIOvQxxT96cwXu 235VfhYojM2fXDbfNWPxuBQ3CCZ6vNs0vL4UWqlzfoEd6aP58Nlk9zaUDjJsNN6Ta8C7 zwY/shXJqYhKFJHZE2dWvBNdmD2NNJhIlhfUFx3q2Iziz5240htT+bztKuNGvDTWTH1g oIsm8rRLS1BYT6ve8UNTjOKBki5DiIYNU0Z1nuUja2wwhHKS7w3x8v1EJCdGmv7RPNR2 N9Zx798HGg7p1HvK7Ilkn3VJFoZDtqUFM4ogAUQfSk3UHHrLWHWcdVlPsHCPQJdWj7Fn g2lQ== X-Gm-Message-State: AOAM533EtNK/gFhh0KuETUFldLkvogaNo+LWq1dtf97ab7gjdPs5HzHl 67pektbKZO4e30HN2jJHIAZ8HUeZm8Dt5A== X-Google-Smtp-Source: ABdhPJzQo0Kei6lVdd6kaw5xckghrnHQGtsO4D6vg6gyYU4ZHIYanDhxzn1765FO+zUr79C1QHVKmw== X-Received: by 2002:a37:a485:: with SMTP id n127mr1692853qke.454.1618238195337; Mon, 12 Apr 2021 07:36:35 -0700 (PDT) Received: from nuc ([142.126.164.150]) by smtp.gmail.com with ESMTPSA id f16sm896816qkl.25.2021.04.12.07.36.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 07:36:34 -0700 (PDT) Sender: Mark Johnston Date: Mon, 12 Apr 2021 10:36:35 -0400 From: Mark Johnston To: Cy Schubert Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: dfff37765ce4 - main - Rename struct device to struct _device Message-ID: References: <202104121336.13CDaI5A029079@gitrepo.freebsd.org> <202104121430.13CEUUIq030729@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202104121430.13CEUUIq030729@slippy.cwsent.com> X-Rspamd-Queue-Id: 4FJrsH6WPTz4Y8p X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=vSlegaSC; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::72e as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [0.15 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.15)[-0.147]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::72e:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::72e:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(1.00)[1.000]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::72e:from]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Apr 2021 14:36:36 -0000 On Mon, Apr 12, 2021 at 07:30:30AM -0700, Cy Schubert wrote: > In message <202104121336.13CDaI5A029079@gitrepo.freebsd.org>, Mark Johnston > wri > tes: > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=dfff37765ce4ea4fd7db4d293b459dc8 > > 4008f411 > > > > commit dfff37765ce4ea4fd7db4d293b459dc84008f411 > > Author: Mark Johnston > > AuthorDate: 2021-04-12 13:32:30 +0000 > > Commit: Mark Johnston > > CommitDate: 2021-04-12 13:32:30 +0000 > > > > Rename struct device to struct _device > > > > types.h defines device_t as a typedef of struct device *. struct device > > is defined in subr_bus.c and almost all of the kernel uses device_t. > > The LinuxKPI also defines a struct device, so type confusion can occur. > > > > This causes bugs and ambiguity for debugging tools. Rename the FreeBSD > > struct device to struct _device. > > > > Reviewed by: gbe (man pages) > > Reviewed by: rpokala, imp, jhb > > MFC after: 1 week > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D29676 > > --- > > share/man/man9/device.9 | 2 +- > > share/man/man9/rman.9 | 6 +++--- > > sys/kern/subr_bus.c | 15 +++++++++------ > > sys/powerpc/include/bus_dma.h | 4 +--- > > sys/sys/pcpu.h | 2 +- > > sys/sys/systm.h | 4 +--- > > sys/sys/types.h | 2 +- > > 7 files changed, 17 insertions(+), 18 deletions(-) > > Not that a name matters much but struct _device gives me a sense that the > struct is ancillary. That's really the intent. struct _device is the internal name and device_t should be used by consumers. > Whereas freebsd_device or fbsd_device is more > descriptive and gives the struct the status it deserves. > > Then again, maybe it's just me. > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > The need of the many outweighs the greed of the few. > >