From nobody Tue Dec 7 20:29:59 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E8AAE18D8EA1 for ; Tue, 7 Dec 2021 20:29:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J7sNl4k7xz4v74 for ; Tue, 7 Dec 2021 20:29:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 82B8E26583 for ; Tue, 7 Dec 2021 20:29:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1B7KTxGh055868 for ; Tue, 7 Dec 2021 20:29:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1B7KTxRj055867 for ports-bugs@FreeBSD.org; Tue, 7 Dec 2021 20:29:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 260268] audio/alsa-utils: fix MANPAGES option (off still installs manpages, installed xmlto breaks 'build') Date: Tue, 07 Dec 2021 20:29:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jcfyecrayz@liamekaens.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638908999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2kWxEXtTwNxWyHtdT7sXDEwOfDmFFZnZ4Fujud+jVa4=; b=Iy8r5DqLwPjbH5RrxHE0aAY1pcC/tuHdcOHknbl92iluPjtoJUgjuj9JZBdu+Ja8nsFhhi WbKR6kZNXntX22MZ3pL3vA8hp34QOJ0hZlFwJw7/vLy3sv0xMqSTcXSfWGcLLUr4MZ+RRv mp1Qt4eMNJ4jpD2z3KNKlrfV9QP3mNH1g38h7e4Kjw6/N+8JHfk5jMIW2R86uuApcRtX7u NGvCWUlkFnjQSc0tgVqipsyB76vkEGO25AXtD8zL3dJqQ7ZEE9514YzkFYB6OnXem4YxAM 2WiYmlCN9MzZmSzD2Z/NSveTLWPpUqkqE84vlPmBslPetrj3S1+7NDHPxFjWsg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638908999; a=rsa-sha256; cv=none; b=CSfTAbPZQoqTFb2kix20C09ZMqS0sFUMn9HQp5qKwwiSXBRjnNT40VWGEvbWqTaHrKqZhp ZV9st7XsF1mNcQpCntDAgOdQ3Y0wxufv+yWcbrvwNp/bzzVVU/+7z00GGIXhu6Kbl9lW0E CCif0ZlS6baiKq2D/tFkVsE69t09iOErbEnxa2xmc330WwFbMqu8jTSOtw2OkHXEAu8DJE Eir9XaOM7aql/5sU3/A25+29VyarbHBd9XhWYtkm0i8a0zsvrdksNo4vqUgLA/OU+dw/sY EdG3ThPDnqf2xzOXs5hwRRxFlh2ZvwADZutMEujYmTM4FOS/0TCxSnvHhfjNFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260268 Bug ID: 260268 Summary: audio/alsa-utils: fix MANPAGES option (off still installs manpages, installed xmlto breaks 'build') Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: jcfyecrayz@liamekaens.com If you have 'textproc/xmlto' installed, 'make -C audio/alsa-utils build' fa= ils: . . man alsactl_init.xml No manual entry for alsactl_init.xml gmake[4]: *** [Makefile:1113: alsactl_init.7] Error 1 When the MANPAGES option was added (May 2021 with update to 1.2.2), the att= empt to use xmlto was flawed a few ways: - configure does not heed ac_cv_prog_xmlto at all, so the attempt to force= the build to use minixmlto does nothing. - the configure process never sets 'xmlto', so the patch to use $(xmlto) results in an empty expansion and the 'No manual entry' failure, but only if xmlto is detected - i.e., only if textproc/xmlto is installed. This is not installed in a poudriere environment, so xmlto support is disabled during '= make configure' (thus hiding the bug, but also causing one of the man pages to n= ot be generated). - if the MANPAGES option is off, man pages are still installed. - if rst2man is installed (py-docutils), a couple other man pages are generated which break 'make check-plist'. If rst2man is not installed, tha= t is detected and two man pages are not generated. The attached patch uses BINARY_ALIAS to use minixmlto instead of the incorr= ect Makefile.am (or Makefile.in) patch attempt. It also adds the missed depend= ency on rst2man. It also shuffles some lines to make portclippy / portlint happy. QA using attached patch: - poudriere testport (ok WITH=3DMANPAGES and WITHOUT=3DMANPAGES) - portclippy (ok) - portlint (ok) --=20 You are receiving this mail because: You are the assignee for the bug.=