From owner-freebsd-current@freebsd.org Tue Oct 4 09:53:21 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 099FBAF38BD for ; Tue, 4 Oct 2016 09:53:21 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: from mail.grem.de (outcast.grem.de [213.239.217.27]) by mx1.freebsd.org (Postfix) with SMTP id 67602A88 for ; Tue, 4 Oct 2016 09:53:19 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: (qmail 47876 invoked by uid 89); 4 Oct 2016 09:46:36 -0000 Received: from unknown (HELO bsd64.grem.de) (mg@grem.de@195.30.121.97) by mail.grem.de with ESMTPA; 4 Oct 2016 09:46:36 -0000 Date: Tue, 4 Oct 2016 11:46:35 +0200 From: Michael Gmelin To: Andriy Gapon Cc: FreeBSD Current , freebsd-mobile@FreeBSD.org Subject: Re: [request for testing] isl, cyapa on chromebooks Message-ID: <20161004114635.64857a29@bsd64.grem.de> In-Reply-To: References: <1e66fc64-cdff-e94b-4b0c-55cb05e2b5a1@FreeBSD.org> <20161003180750.744dae0a@bsd64.grem.de> <20161003222528.56d46787@bsd64.grem.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; amd64-portbld-freebsd10.2) X-Face: $wrgCtfdVw_H9WAY?S&9+/F"!41z'L$uo*WzT8miX?kZ~W~Lr5W7v?j0Sde\mwB&/ypo^}> +a'4xMc^^KroE~+v^&^#[B">soBo1y6(TW6#UZiC]o>C6`ej+i Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWJBwe5BQDl LASZU0/LTEWEfHbyj0Txi32+sKrp1Mv944X8/fm1rS+cAAAACXBIWXMAAAsTAAAL EwEAmpwYAAAAB3RJTUUH3wESCxwC7OBhbgAAACFpVFh0Q29tbWVudAAAAAAAQ3Jl YXRlZCB3aXRoIFRoZSBHSU1QbbCXAAAAAghJREFUOMu11DFvEzEUAGCfEhBVFzuq AKkLd0O6VrIQsLXVSZXoWE5N1K3DobBBA9fQpRWc8OkWouaIjedWKiyREOKs+3PY fvalCNjgLVHeF7/3bMtBzV8C/VsQ8tecEgCcDgrzjekwKZ7TwsJZd/ywEKwwP+ZM 8P3drTsAwWn2mpWuDDuYiK1bFs6De0KUUFw0tWxm+D4AIhuuvZqtyWYeO7jQ4Aea 7jUqI+ixhQoHex4WshEvSXdood7stlv4oSuFOC4tqGcr0NjEqXgV4mMJO38nld4+ xKNxRDon7khyKVqY7YR4d+Cg0OMrkWXZOM7YDkEfKiilCn1qYv4mighZiynuHHOA Wq9QJq+BIES7lMFUtcikMnkDGHUoncA+uHgrP0ctIEqfwLHzeSo+eUA66AqzwN6n 2ZHJhw6Qh/PoyC/QENyEyC/AyNjq74Bs+3UH0xYwzDUC4B97HgLocg1QLYgDDO1v f3UX9Y307Ew4AHh67YAFFsxEpkXwpXY3eIgMhAAE3R19L919nNnuD2wlPcDE3UeT L2ytEICQib9BXgS2fU8PrD82ToYO1OEmMSnYTjSqSv9wdC0tPYC+rQRQD9ESnldF CyqfmiYW+tlALt8gH2xrMdC/youbjzPXEun+/ReXsMCDyve3dZc09fn2Oas8oXGc Jj6/fOeK5UmSMPmf/jL+GD8BEj0k/Fn6IO4AAAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2016 09:53:21 -0000 On Tue, 4 Oct 2016 01:04:10 +0300 Andriy Gapon wrote: > On 03/10/2016 23:25, Michael Gmelin wrote: > > On Mon, 3 Oct 2016 19:41:17 +0300 > > Andriy Gapon wrote: > > > >> On 03/10/2016 19:07, Michael Gmelin wrote: > >>> I upgraded the latter the r306641, applied your patches (cleanly) > >>> and ran "make kernel" (GENERIC kernel), added the entries to > >>> device.hints and rebooted. Unfortunately ig4 won't load: > >>> > >>> # kldload ig4 > >>> link_elf_obj: symbol iicbus_transfer_desc undefined > >>> linker_load_file: Unsupported file type > >> > >> Hmm, seems like forgot to declare the iicbus module dependency. > >> Could you please kldload iicbus and see if that helps? > >> Meanwhile I'll add the dependency. > > > > Unfortunately this doesn't help, you should be able to reproduce it > > yourself without access to the actual hardware though. > > > > I worked around this by adding the iicbus dependency to ig4_pci.c > > (and also to "files"). > > Okay, this should be in the latest patch anyway. Based on what you wrote, I wasn't aware that there was a new patch. I downloaded the latest version from the same URL as your first one and built a new kernel. > > > Now loading ig4 works and both lynx point controllers are detected. > > Loading isl doesn't create any output and doesn't seem to detect any > > devices. Also, devinfo shows both controllers (ig4iic0, ig4iic1), > > but no iicbus devices. > > > > # devinfo | grep iic > > ig4iic0 > > ig4iic1 > > Is there anything interesting from from ig4 in the log / dmesg? > Could you please check that your copy of the patch contains this > chunk? @@ -549,7 +780,7 @@ ig4iic_attach(ig4iic_softc_t *sc) > IG4_CTL_RESTARTEN | > IG4_CTL_SPEED_STD); > > - sc->smb = device_add_child(sc->dev, "smbus", -1); > + sc->smb = device_add_child(sc->dev, "iicbus", -1); > if (sc->smb == NULL) { > device_printf(sc->dev, "smbus driver not found\n"); > error = ENXIO; > That code was in there, yes. iicbus(0|1) actually show up in devinfo -v, but nothing else works. You can find a log file and various outputs (dmesg, devinfo etc) here: https://people.freebsd.org/~grembo/c720-20161104.log -m -- Michael Gmelin