From owner-freebsd-bugs@FreeBSD.ORG Thu Sep 27 23:00:05 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 67EF316A4C2 for ; Thu, 27 Sep 2007 23:00:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3794713C458 for ; Thu, 27 Sep 2007 23:00:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l8RN05xQ048233 for ; Thu, 27 Sep 2007 23:00:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l8RN05kd048232; Thu, 27 Sep 2007 23:00:05 GMT (envelope-from gnats) Resent-Date: Thu, 27 Sep 2007 23:00:05 GMT Resent-Message-Id: <200709272300.l8RN05kd048232@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7C09716A50F for ; Thu, 27 Sep 2007 22:55:34 +0000 (UTC) (envelope-from dan@kulesh.obluda.cz) Received: from smtp1.kolej.mff.cuni.cz (smtp1.kolej.mff.cuni.cz [78.128.192.4]) by mx1.freebsd.org (Postfix) with ESMTP id F032E13C4A3 for ; Thu, 27 Sep 2007 22:55:33 +0000 (UTC) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (openvpn.ms.mff.cuni.cz [195.113.20.87]) by smtp1.kolej.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id l8RMtHuK089590 for ; Fri, 28 Sep 2007 00:55:18 +0200 (CEST) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (localhost. [127.0.0.1]) by kulesh.obluda.cz (8.14.1/8.14.1) with ESMTP id l8RMtHSW001441 for ; Fri, 28 Sep 2007 00:55:17 +0200 (CEST) (envelope-from dan@kulesh.obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.14.1/8.13.8/Submit) id l8RMtGU2001440; Fri, 28 Sep 2007 00:55:16 +0200 (CEST) (envelope-from dan) Message-Id: <200709272255.l8RMtGU2001440@kulesh.obluda.cz> Date: Fri, 28 Sep 2007 00:55:16 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/116697: [ PATCH ] ifconfig's name argument has no efect on /dev/net/ X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2007 23:00:05 -0000 >Number: 116697 >Category: kern >Synopsis: [ PATCH ] ifconfig's name argument has no efect on /dev/net/ >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Sep 27 23:00:04 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 6.2-STABLE i386 >Organization: Obludarium >Environment: FreeBSD 6.2-STABLE src/sys/net/if.c,v 1.234.2.21 2007/07/13 01:26:44 >Description: All network interfaces has special device node under /dev/net/ directory ifconfig's name argument allow renaming of interface, but it has no effect on /dev/net content. It create incostistence between ifconfig's view of interface list and /dev/net/ content Althought detected and analysed on RELENG-6, it does apply to CURRENT as well. >How-To-Repeat: ifconfig vlan0 create ZEROVLAN ls /dev/net/ >Fix: Recreate device nodes on interface name change. --- sys/net/if.c.ORIG 2007-09-27 10:05:10.000000000 +0200 +++ sys/net/if.c 2007-09-27 10:05:10.000000000 +0200 @@ -1393,6 +1393,14 @@ sdl->sdl_data[--namelen] = 0xff; IFA_UNLOCK(ifa); + destroy_dev(ifdev_byindex(ifp->if_index)); + ifdev_byindex(ifp->if_index) = make_dev(&net_cdevsw, + unit2minor(ifp->if_index), + UID_ROOT, GID_WHEEL, 0600, "%s/%s", + net_cdevsw.d_name, ifp->if_xname); + make_dev_alias(ifdev_byindex(ifp->if_index), "%s%d", + net_cdevsw.d_name, ifp->if_index); + EVENTHANDLER_INVOKE(ifnet_arrival_event, ifp); /* Announce the return of the interface. */ rt_ifannouncemsg(ifp, IFAN_ARRIVAL); >Release-Note: >Audit-Trail: >Unformatted: