From owner-cvs-all@FreeBSD.ORG Tue Nov 22 20:41:38 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 567E316A41F; Tue, 22 Nov 2005 20:41:38 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id E253C43D60; Tue, 22 Nov 2005 20:41:36 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id jAMKfZHD084122; Tue, 22 Nov 2005 22:41:35 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 32988-01; Tue, 22 Nov 2005 22:41:24 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id jAMKcAZw084028 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Nov 2005 22:38:10 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.4/8.13.4) id jAMKcJBQ099846; Tue, 22 Nov 2005 22:38:20 +0200 (EET) (envelope-from ru) Date: Tue, 22 Nov 2005 22:38:19 +0200 From: Ruslan Ermilov To: John Baldwin Message-ID: <20051122203819.GA94180@ip.net.ua> References: <200511212201.jALM1Ggp080941@repoman.freebsd.org> <20051122143721.GE65080@ip.net.ua> <200511221050.41796.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7JfCtLOvnd9MIVvH" Content-Disposition: inline In-Reply-To: <200511221050.41796.jhb@freebsd.org> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci_link.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2005 20:41:38 -0000 --7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 22, 2005 at 10:50:39AM -0500, John Baldwin wrote: > On Tuesday 22 November 2005 09:37 am, Ruslan Ermilov wrote: > > On Mon, Nov 21, 2005 at 10:01:16PM +0000, John Baldwin wrote: > > > jhb 2005-11-21 22:01:16 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/acpica acpi_pci_link.c > > > Log: > > > Fix the code to look up the BIOS IRQ for a given link device by rea= ding > > > the IRQ set by the BIOS in existing devices to actually get the cor= rect > > > bus number of the child PCI bus. I was not reading the bus number = =66rom > > > the bridge device correctly. The __BUS_ACCESSOR() macros (from whi= ch > > > pcib_get_bus() is built) assume that the passed in argument is a ch= ild > > > device. However, at the time I'm reading the bus there is no child > > > device yet, so I was passing in the pcib device as the child device. > > > The parent of the pcib device probably returned an error in the cas= e of > > > a host bridge, thus resulting in random stack garbage for the bus > > > number. For PCI-PCI bridges, the bus number being used was actually t= he > > > subvendor of the PCI-PCI bridge device itself. > > > > > > MFC after: 1 week > > > > > > Revision Changes Path > > > 1.49 +15 -3 src/sys/dev/acpica/acpi_pci_link.c > > > > Looks like I no longer need these hw.pci.link.LNK[A-D].irq=3D11 > > in /boot/loader.conf after this change. >=20 > Woah, that's a good fix then. This was on a T43? >=20 No, 600X. I tried verbose booting with and without ACPI, and with and without these tunables, and don't see any difference. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --7JfCtLOvnd9MIVvH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDg4G7qRfpzJluFF4RAhuSAJ9FRpLZPTq36P0Y5fUccWD5kzZCLwCfUqGg DzJU7BykifDZntwgpgn+Zqs= =vlim -----END PGP SIGNATURE----- --7JfCtLOvnd9MIVvH--