From owner-svn-src-all@FreeBSD.ORG Wed Apr 27 19:44:51 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84A9E106566B; Wed, 27 Apr 2011 19:44:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 596798FC1B; Wed, 27 Apr 2011 19:44:51 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 0084D46B42; Wed, 27 Apr 2011 15:44:51 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 7AEB48A02E; Wed, 27 Apr 2011 15:44:50 -0400 (EDT) From: John Baldwin To: obrien@freebsd.org Date: Wed, 27 Apr 2011 15:44:47 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <201104260409.p3Q49KaJ006272@svn.freebsd.org> <201104271048.33325.jhb@freebsd.org> <20110427193550.GA79786@dragon.NUXI.org> In-Reply-To: <20110427193550.GA79786@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201104271544.47729.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Wed, 27 Apr 2011 15:44:50 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221053 - head/usr.bin/rlogin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2011 19:44:51 -0000 On Wednesday, April 27, 2011 3:35:50 pm David O'Brien wrote: > On Wed, Apr 27, 2011 at 10:48:33AM -0400, John Baldwin wrote: > > For changing WARNS, 'make universe' works well > > I have to disagree. Due to its silent failing, it is only suitable for > what PHK added it for -- "what if" changes. > [Message-ID: <13101.1227520743@critter.freebsd.dk>] > > One has to do all the various greps of the output in order to be > confident of their belief of the results. > > We really need a new target that builds more normal (fails on first > error) and makes it obvious when there is a failure. make tinderbox already does this. It gives you a nice summary at the end if anything failed. If things do fail, yes, you have to look in the listed files to find the errors, but 'make tinderbox' tells you exactly which files to check. For example: -------------------------------------------------------------- >>> make universe completed on Wed Apr 27 15:05:23 EDT 2011 (started Wed Apr 27 14:09:08 EDT 2011) -------------------------------------------------------------- Tinderbox failed: mips AR71XX kernel failed, check _.mips.AR71XX for details mips MALTA64 kernel failed, check _.mips.MALTA64 for details .... -- John Baldwin