From owner-svn-src-head@freebsd.org Thu Nov 24 19:11:28 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69913C535DD; Thu, 24 Nov 2016 19:11:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4462067D; Thu, 24 Nov 2016 19:11:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id B265810A998; Thu, 24 Nov 2016 14:11:26 -0500 (EST) From: John Baldwin To: Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?= Cc: Marcelo Araujo , araujo@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r309109 - head/lib/libutil Date: Thu, 24 Nov 2016 11:11:21 -0800 Message-ID: <2094160.1ufjjsmd6m@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; ) In-Reply-To: <861sy0n8re.fsf@desk.des.no> References: <201611241450.uAOEoLA5079215@repo.freebsd.org> <861sy0n8re.fsf@desk.des.no> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Thu, 24 Nov 2016 14:11:26 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 19:11:28 -0000 On Thursday, November 24, 2016 05:27:17 PM Dag-Erling Sm=F8rgrav wrote:= > Marcelo Araujo writes: > > We have code review, we have some many ways for communication, even= > > revert a commit if needed. >=20 > No. This is the kind of mistake where the code will seem to work jus= t > fine and end up in a release before a user suddenly discovers that th= ey > have two instances of the same daemon running and trashing their data= . > If I remember correctly, the last time someone touched flopen(), > everything worked except 'service mountd reload' stopped working. Of course, there's only one person who has touched flopen: % svn log -q flopen.c | awk -F \| '/^r/ { print $2 }' | sort | uniq -c 12 des=20 Perhaps you were just warning yourself? :) --=20 John Baldwin