From owner-freebsd-bugs@FreeBSD.ORG  Tue Feb 21 18:50:08 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8E6FA106566B
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 21 Feb 2012 18:50:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 75A9D8FC08
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 21 Feb 2012 18:50:08 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q1LIo8KE078316
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 21 Feb 2012 18:50:08 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q1LIo8LL078315;
	Tue, 21 Feb 2012 18:50:08 GMT (envelope-from gnats)
Date: Tue, 21 Feb 2012 18:50:08 GMT
Message-Id: <201202211850.q1LIo8LL078315@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Garance A Drosehn <gad@FreeBSD.org>
Cc: 
Subject: Re: conf/165331: periodic security run output gives false positives
 after 1 year
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Garance A Drosehn <gad@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Feb 2012 18:50:08 -0000

The following reply was made to PR conf/165331; it has been noted by GNATS.

From: Garance A Drosehn <gad@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: conf/165331: periodic security run output gives false positives
 after 1 year
Date: Tue, 21 Feb 2012 12:32:40 -0500

 Note that catmsgs() function in periodic/security/800.loginfail
 starts off with:
 
     find ${LOG} -name 'auth.log.*' -mtime -2   | [...etc...]
 
 Note the '-mtime -2' on that 'find' command.  It is *not* reading
 all archived logs on the disk.  It is reading all files which have
 a last-modified time within 2 days of the time the command is
 executed.
 
 It would still be a good idea to do something to fix the problem
 as described, but that problem would be fixed by having the log
 files rotated just once-per-year.  (Or it could be fixed by
 including the year in timestamps written to the log files).
 
 -- 
 Garance Alistair Drosehn            =   gad@gilead.netel.rpi.edu
 Senior Systems Programmer           or  gad@freebsd.org
 Rensselaer Polytechnic Institute    or  drosih@rpi.edu