From owner-cvs-sys Sat Apr 26 11:06:57 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id LAA01157 for cvs-sys-outgoing; Sat, 26 Apr 1997 11:06:57 -0700 (PDT) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id LAA01138; Sat, 26 Apr 1997 11:06:47 -0700 (PDT) Received: from herring.nlsystems.com (herring.nlsystems.com [10.0.0.2]) by nlsystems.com (8.8.5/8.8.5) with SMTP id TAA10172; Sat, 26 Apr 1997 19:06:50 +0100 (BST) Date: Sat, 26 Apr 1997 19:06:50 +0100 (BST) From: Doug Rabson To: KATO Takenori cc: CVS-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-sys@FreeBSD.org Subject: Re: cvs commit: src/sys/miscfs/union union_vnops.c In-Reply-To: <199704261343.GAA20133@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk On Sat, 26 Apr 1997, KATO Takenori wrote: > kato 97/04/26 06:43:27 > > Modified: sys/miscfs/union union_vnops.c > Log: > Do nothing instead of adjusting un_flags when (uppervp is locked) && > (UN_ULOCK is not set) in union_lock. This condition may indicate > race. DIAGNOSTIC kernel still panic here. I don't think this is right. I just had a lockmgr panic using the 1.28 version of this file (the one which played with the flags). It turned out that update had the uppervp locked and the union node should have locked the uppervp itself which would have waited until update had finished before continuing. In the same situation for 1.29 we would not lock uppervp at all which just seems wrong. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891