From owner-freebsd-fs@FreeBSD.ORG Wed Jun 29 12:08:50 2011 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C186D1065672; Wed, 29 Jun 2011 12:08:50 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 539E38FC0C; Wed, 29 Jun 2011 12:08:50 +0000 (UTC) Received: from outgoing.leidinger.net (p4FC4623A.dip.t-dialin.net [79.196.98.58]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id AA5AB84400D; Wed, 29 Jun 2011 14:08:37 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [IPv6:fd73:10c7:2053:1::3:102]) by outgoing.leidinger.net (Postfix) with ESMTP id E0CAF202B; Wed, 29 Jun 2011 14:08:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1309349315; bh=l2pXF+mfjvYy+pxIsAc2NWMWcnQgK+OiHWm7BM47EuI=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=PsePKWILa2hhHDAIiIIcJlAGQgjHgJJ0T8ZSYLtvC/vywxI25vc/z/Ji1FzJk/qzb Rm9hQhMCbv4087dsQe62xaBg5vT/WMXsg7Bqct7FDIcMpMUCG6zjDvWnJqaryB3BYR cR5Dh/7uWiI9qEIh2iOwm/2S87riddEXSYtSU3MJ0armUk1jah9mExQn6NvLDDCDjA NCOGmQHxfP75I5Cz6Br02roMOqXqciWDVJptV5FxBTIdqvqNWU/1CLEn2AlxG3GrKH EqjiYwUd/Fm7iHCU5N+99YcqmUvbbOAUgMYQW5xiF+6BniBnMTcRS+TLDL9BPX+nzI JLhHYPI+HIN0Q== Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.14.4/Submit) id p5TC8YAP030401; Wed, 29 Jun 2011 14:08:34 +0200 (CEST) (envelope-from Alexander@Leidinger.net) X-Authentication-Warning: webmail.leidinger.net: www set sender to Alexander@Leidinger.net using -f Received: from pslux.ec.europa.eu (pslux.ec.europa.eu [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Wed, 29 Jun 2011 14:08:34 +0200 Message-ID: <20110629140834.59115su2x8nk8gjm@webmail.leidinger.net> Date: Wed, 29 Jun 2011 14:08:34 +0200 From: Alexander Leidinger To: Glen Barber References: <20110628203228.GA4957@onyx.glenbarber.us> <20110629104633.26824evikzh8tgtl@webmail.leidinger.net> <4E0B006C.8050000@FreeBSD.org> <4E0B0AAB.5030300@FreeBSD.org> In-Reply-To: <4E0B0AAB.5030300@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.6) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: AA5AB84400D.A3772 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-0.1, required 6, autolearn=disabled, DKIM_SIGNED 0.10, DKIM_VALID -0.10, DKIM_VALID_AU -0.10) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1309954118.03761@I4juFNFdwA5+020akKjJlg X-EBL-Spam-Status: No Cc: fs@FreeBSD.org Subject: Re: [RFC] [patch] periodic status-zfs: list pools in daily emails X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2011 12:08:50 -0000 Quoting Glen Barber (from Wed, 29 Jun 2011 07:21:15 -0400): > On 6/29/11 6:37 AM, Glen Barber wrote: >> I will reply later today with of the script with an unhealthy pool, and >> will make listing the pools configurable. I imagine an empty line would >> certainly make it more readable in either case. I would be reluctant to >> replace 'status' output with 'list' output for healthy pools mostly to >> avoid headaches for people parsing their daily email, specifically >> looking for (or missing) 'all pools are healthy.' >> > > Might as well do this now, in case I don't have time later today. > > For completeness, I took one drive in both of my pools offline. (Pardon > the long lines.) I also made listing the pools configurable, enabled by > default, but it runs only if daily_status_zfs_enable=YES. > > Feedback would be appreciated. Good news: I see no problems in your patch. Bad news: I detected that I forgot to add docs to the man page of periodic.conf for the daily_status_zfs_enable, and as such I can not complain that you forgot to do so for the daily_status_zfs_zpool_list_enable switch. Bye, Alexander. -- Monday, n.: In Christian countries, the day after the baseball game. -- Ambrose Bierce, "The Devil's Dictionary" http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137