From owner-svn-src-projects@FreeBSD.ORG Mon Apr 15 04:17:40 2013 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 616F3C42; Mon, 15 Apr 2013 04:17:40 +0000 (UTC) (envelope-from neelnatu@gmail.com) Received: from mail-ie0-x22f.google.com (mail-ie0-x22f.google.com [IPv6:2607:f8b0:4001:c03::22f]) by mx1.freebsd.org (Postfix) with ESMTP id 194A589; Mon, 15 Apr 2013 04:17:40 +0000 (UTC) Received: by mail-ie0-f175.google.com with SMTP id c12so5354393ieb.34 for ; Sun, 14 Apr 2013 21:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=ohf6O4DR+jWug7TQVEiMlf4ESc4e3yqgfFK/maeCxGw=; b=QFX2sEtplmldzMWL9yeKB27D1OaGvtVjJiCXKIrlW7baiY4tHObhxEUGlbajoJgLLO v8DWyoRUbqUfBfOTMyCWhCIvFMAL5lfr/ofRNg3JmagrxK4Etw2/staTY7eeFOMV24CV U1/CE1D/xTUmQJ+5FGYJgmAJWTQayq4Zm1lRYx8epzIPvHcGC1ZYpTB0HevddTGuEiXX oFTqG214slNP5uBtCz+8JWdHaaiWtFo09fH1XbRkySzi0b6l+FI9/ZHKyxJ0BOEcVWP1 fVtXcbcIr5JrPReEIq/AtIq/bNsl5d42DRUfXcvZn3uwbyeC3lpllWHVgWfIvbblLmfN B1fw== MIME-Version: 1.0 X-Received: by 10.43.62.12 with SMTP id wy12mr10988306icb.19.1365999459792; Sun, 14 Apr 2013 21:17:39 -0700 (PDT) Received: by 10.43.9.138 with HTTP; Sun, 14 Apr 2013 21:17:39 -0700 (PDT) In-Reply-To: <516B73A5.6000909@freebsd.org> References: <201304110652.r3B6qJmP055359@svn.freebsd.org> <516B73A5.6000909@freebsd.org> Date: Sun, 14 Apr 2013 21:17:39 -0700 Message-ID: Subject: Re: svn commit: r249353 - projects/bhyve_svm/sys/amd64/vmm/amd From: Neel Natu To: Julian Elischer Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-src-projects@freebsd.org, "src-committers@freebsd.org" , Neel Natu X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Apr 2013 04:17:40 -0000 Hi Julian, On Sun, Apr 14, 2013 at 8:27 PM, Julian Elischer wrote: > On 4/11/13 2:52 PM, Neel Natu wrote: > >> Author: neel >> Date: Thu Apr 11 06:52:19 2013 >> New Revision: 249353 >> URL: http://svnweb.freebsd.org/**changeset/base/249353 >> >> Log: >> Provide functions to manipulate the guest state in the VMCB. >> Submitted by: Anish Gupta (akgupt3@gmail.com) >> >> Added: >> projects/bhyve_svm/sys/amd64/**vmm/amd/vmcb.c (contents, props >> changed) >> Modified: >> projects/bhyve_svm/sys/amd64/**vmm/amd/vmcb.h >> >> Added: projects/bhyve_svm/sys/amd64/**vmm/amd/vmcb.c >> ==============================**==============================** >> ================== >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ projects/bhyve_svm/sys/amd64/**vmm/amd/vmcb.c Thu Apr 11 06:52:19 >> 2013 (r249353) >> @@ -0,0 +1,383 @@ >> +/*- >> + * Copyright (c) 2013 Anish Gupta (akgupt3@gmail.com) >> + * All rights reserved. >> + * >> + * Redistribution and use in source and binary forms, with or without >> + * modification, are permitted provided that the following conditions >> + * are met: >> + * 1. Redistributions of source code must retain the above copyright >> + * notice, this list of conditions and the following disclaimer. >> + * 2. Redistributions in binary form must reproduce the above copyright >> + * notice, this list of conditions and the following disclaimer in the >> + * documentation and/or other materials provided with the >> distribution. >> + * >> + * THIS SOFTWARE IS PROVIDED BY NETAPP, INC ``AS IS'' AND >> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE >> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR >> PURPOSE >> + * ARE DISCLAIMED. IN NO EVENT SHALL NETAPP, INC OR CONTRIBUTORS BE >> LIABLE >> + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR >> CONSEQUENTIAL >> + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE >> GOODS >> + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) >> + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, >> STRICT >> + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY >> WAY >> + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF >> + * SUCH DAMAGE. >> + * >> + * $FreeBSD$ >> + */ >> + >> +#include >> +__FBSDID("$FreeBSD$"); >> + >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> + >> +#include "vmcb.h" >> > > about here there should be a comment explianing what a VMCB is and giving > background information.. > > Fixed in r249493. > This is true for a lot of files being added these days.. I just picked on > this one randomly. No problem. best Neel > > > Julian > > > > + >> +/* >> + * Initialize SVM h/w context i.e. the VMCB control and saved state >> areas. >> + */ >> +int >> > >