From owner-freebsd-current@FreeBSD.ORG  Thu Nov  1 03:57:41 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A657B16A421
	for <current@freebsd.org>; Thu,  1 Nov 2007 03:57:41 +0000 (UTC)
	(envelope-from nslay@comcast.net)
Received: from alnrmhc16.comcast.net (alnrmhc16.comcast.net [206.18.177.56])
	by mx1.freebsd.org (Postfix) with ESMTP id 3B09813C48A
	for <current@freebsd.org>; Thu,  1 Nov 2007 03:57:41 +0000 (UTC)
	(envelope-from nslay@comcast.net)
Received: from lightbulb.local
	(c-68-35-224-189.hsd1.fl.comcast.net[68.35.224.189])
	by comcast.net (alnrmhc16) with ESMTP
	id <20071101032322b16006tu7le>; Thu, 1 Nov 2007 03:23:23 +0000
Message-ID: <4729467C.3080907@comcast.net>
Date: Wed, 31 Oct 2007 23:22:36 -0400
From: Nathan Lay <nslay@comcast.net>
User-Agent: Thunderbird 2.0.0.6 (X11/20070805)
MIME-Version: 1.0
To: Andrey Chernov <ache@nagual.pp.ru>,  current@freebsd.org
References: <20071101025937.GB94332@nagual.pp.ru>
In-Reply-To: <20071101025937.GB94332@nagual.pp.ru>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: non-functional backout for review
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Nov 2007 03:57:41 -0000

Andrey Chernov wrote:
> Some people complaints that new check in __isctype() is not human readable 
> and requests for backout. Compiler gives almost identical code for old and 
> new excepting non-optimized case where non-human readable one wins. I am a 
> bit tired to change it forth and back, so ask for final consensus here.
>
> Old one
>
> return (_c < 0 || _c >= 128) ? 0 :
>
> New one (requests for backout)
>
> return (_c & ~0x7F) ? 0 :
>
>   
Why not just comment out the old version just above the new version?

Best Regards,
Nathan Lay