From owner-svn-src-all@FreeBSD.ORG Tue Mar 20 17:00:52 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1CD14106564A; Tue, 20 Mar 2012 17:00:52 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 68A838FC19; Tue, 20 Mar 2012 17:00:51 +0000 (UTC) Received: by vcmm1 with SMTP id m1so335349vcm.13 for ; Tue, 20 Mar 2012 10:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=yxKnFOW9GjyD5oAFXrFsgpbXt1o6nvusXoqvP0QkmMs=; b=DLJgPMgrHoum3BxlDYZVT4SX3GxMJCX3+ioqgr2TJ4s51vG3s/8JfLYPKEiYrAPex8 pplwdSyS3Z0AQjVAYELIIGukxMNL4iOr0og/txNHxOlQOdDsYwhdtTLBHh69V2dJjWK1 5iYfA+9Ideoaoh24Q9pNlF292lDdswiMXB4nI+WwoJ1Ga0KWDMNb4q1P3ZE5PKez6q7l ROAWO1UilRKBNiJss8p/VpriSAGa/8u6eMitl+jBTXZwSQnzY19o8sS/HoBsc9HxytO1 +/DR+VEsQKCEossYCjQ7Km7kkyr81vjoSqtO1snl1Fdue2+DiFW3d0TCXE5P7acXIAzC GagA== MIME-Version: 1.0 Received: by 10.52.93.77 with SMTP id cs13mr221353vdb.71.1332262850564; Tue, 20 Mar 2012 10:00:50 -0700 (PDT) Received: by 10.52.171.167 with HTTP; Tue, 20 Mar 2012 10:00:50 -0700 (PDT) In-Reply-To: <20120320143611.GH30704@FreeBSD.org> References: <201203162032.q2GKWBRV033715@svn.freebsd.org> <20120319194431.GD30704@FreeBSD.org> <20120320143611.GH30704@FreeBSD.org> Date: Tue, 20 Mar 2012 18:00:50 +0100 Message-ID: From: Davide Italiano To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, George Neville-Neil , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233045 - in head/sys: conf kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2012 17:00:52 -0000 2012/3/20 Gleb Smirnoff : > On Mon, Mar 19, 2012 at 09:06:36PM +0100, Davide Italiano wrote: > D> >> These indented ifdefs look like a major violation of style used throughout > D> >> the FreeBSD kernel code. Can you please keep with common style? > D> >> > D> > > D> > Heh, > D> > sorry, also Juli Mallet noticed this, I'm writing a fix for this and > D> > after I'll have approval from my mentor I'll commit. > > Looks okay, apart from additional empty line in NOTES. Isn't single > empty line enough? > > -- > Totus tuus, Glebius. Well, I removed that in my previous commit. It was a mistake. But if you think it's ok to remove that line, I have no objections on this. Davide