From owner-svn-src-head@freebsd.org Sat Jul 8 17:02:53 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 98F3FD9E60B for ; Sat, 8 Jul 2017 17:02:53 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 31B751F86 for ; Sat, 8 Jul 2017 17:02:52 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 3f243ea8-63ff-11e7-b2f5-7fbc454a3a22 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id 3f243ea8-63ff-11e7-b2f5-7fbc454a3a22; Sat, 08 Jul 2017 17:02:39 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v68H2brL009261; Sat, 8 Jul 2017 11:02:37 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1499533357.87595.78.camel@freebsd.org> Subject: Re: svn commit: r320803 - head/sbin/mount From: Ian Lepore To: rgrimes@freebsd.org, Edward Tomasz Napierala Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sat, 08 Jul 2017 11:02:37 -0600 In-Reply-To: <201707081650.v68GoHgS068308@pdx.rh.CN85.dnsmgr.net> References: <201707081650.v68GoHgS068308@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jul 2017 17:02:53 -0000 On Sat, 2017-07-08 at 09:50 -0700, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] > > > > Author: trasz > > Date: Sat Jul  8 11:06:27 2017 > > New Revision: 320803 > > URL: https://svnweb.freebsd.org/changeset/base/320803 > > > > Log: > >   Fix "mount -uw /" when the filesystem type doesn't match. > >    > >   This basically makes "mount -uw /" work when the filesystem > >   mounted on / is NFS, but the one configured in fstab(5) is UFS, > >   which can happen when you forget to modify fstab. > Please do not silence user errors because they are inconvinient, > this is a configuration error and the system should fail to  > mount the incorrectly configured root. > > If we start changing things to silently ignore user configuration > errors we are going down a very slippery road. > IMO, this change fixes the right problem, but maybe does so the wrong way.  Mount -u is by definition an update to an existing mount.  There should be no need to consult /etc/fstab for an existing mount since the info is available from the kernel. Note that I say the foregoing with my user hat on.  I haven't looked at the code to see if there's some reason why my common-sensical way of thinking about it is actually impossible to implement for some reason. -- Ian