From owner-cvs-src@FreeBSD.ORG  Sun Oct 10 15:36:55 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0A18016A4CE; Sun, 10 Oct 2004 15:36:55 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6060C43D46; Sun, 10 Oct 2004 15:36:54 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id i9AFaqSl089783;
	Sun, 10 Oct 2004 17:36:53 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Takahashi Yoshihiro <nyan@jp.FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sat, 09 Oct 2004 02:39:58 +0900."
             <20041009.023958.41719880.nyan@jp.FreeBSD.org> 
Date: Sun, 10 Oct 2004 17:36:52 +0200
Message-ID: <89782.1097422612@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: sos@FreeBSD.org
Subject: Re: cvs commit: src/sys/geom geom_pc98.c src/sys/dev/ata ata-all.h
	ata-cbus.c ata-disk.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Oct 2004 15:36:55 -0000

In message <20041009.023958.41719880.nyan@jp.FreeBSD.org>, Takahashi Yoshihiro 
writes:
>In article <200410071737.i97Hb9TU038301@repoman.freebsd.org>
>Søren Schmidt <sos@FreeBSD.org> writes:
>
>> sos         2004-10-07 17:37:09 UTC
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     sys/geom             geom_pc98.c 
>>     sys/dev/ata          ata-all.h ata-cbus.c ata-disk.c 
>>   Log:
>>   Move the PC98 specific geometry "gunk" to geom_pc98.c where it belongs.
>>   This also adds support for bigger disks on the controller I have access to,
>>   and maybe others if I understood the adhoc methods used on those.
>>   
>>   Those with more PC98 bigdrive controllers it is hereby invited to add/fix
>>   support for those in geom_pc98.c and not using #ifdef PC98 all over the place.
>
>This broke non-ATA disk supports.  We need to use different way for
>geometry translation between ATA and non-ATA disks.  And, your
>'BigDrive' support has some problems, it cannot use 'BigDrive' as root
>filesystem and it is incompatibility with the other OSs.

Then conditionalize the code in geom_pc98 on the provider name starting
with "ad".

All PC98 disk layout relevant code should be in geom_pc98 and not
in diskdrivers.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.