From owner-svn-src-all@FreeBSD.ORG Tue Dec 17 18:17:52 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 782DD703; Tue, 17 Dec 2013 18:17:52 +0000 (UTC) Received: from mail-wg0-x231.google.com (mail-wg0-x231.google.com [IPv6:2a00:1450:400c:c00::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 704331E7A; Tue, 17 Dec 2013 18:17:51 +0000 (UTC) Received: by mail-wg0-f49.google.com with SMTP id x12so6317427wgg.28 for ; Tue, 17 Dec 2013 10:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=s8/o5uo+Boh4UNDRAoKGJ1uI2MhNw2KUlj8/5A/dcuk=; b=slQuDv5S9eW5Nr+ju5hTGNurn0P5LV4aCWZF0ZzGeOKl47XwLBWjY2UPO/zlLgsSwk uYscEfE1HLLBYSn0P2Uenf2EbvPj2T1XHwLAoCPwjvvLpMI7i/+uZd5lrc+8MEQLGhAK flYTk6iWkuiUVDq/JDHlVtCQwWVNtmdEO5jiIECSvNA1lFUIn571Yi/vLzELcIrJb3rv MiYmY/1frXvBcz7Y+XImnq+jviML9f6CsHSXZPkhac+xdECXA3qS/6cJcKCfKKkgYKIV SjdoBb9dTZPD4xJToWrFBJR4LdPMU4wmJhVmZWWwQbH+gV4b8unQeE6YdN2VlMVzcTK2 0zQA== X-Received: by 10.180.101.197 with SMTP id fi5mr4429469wib.46.1387304269796; Tue, 17 Dec 2013 10:17:49 -0800 (PST) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPSA id z2sm18631879wiy.11.2013.12.17.10.17.47 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 17 Dec 2013 10:17:48 -0800 (PST) Date: Tue, 17 Dec 2013 19:17:45 +0100 From: Mateusz Guzik To: John Baldwin Subject: Re: svn commit: r259407 - head/sys/kern Message-ID: <20131217181745.GB7535@dft-labs.eu> References: <201312150411.rBF4Bhtg018852@svn.freebsd.org> <201312171141.49251.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201312171141.49251.jhb@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Mateusz Guzik X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Dec 2013 18:17:52 -0000 On Tue, Dec 17, 2013 at 11:41:49AM -0500, John Baldwin wrote: > On Saturday, December 14, 2013 11:11:43 pm Mateusz Guzik wrote: > > Author: mjg > > Date: Sun Dec 15 04:11:43 2013 > > New Revision: 259407 > > URL: http://svnweb.freebsd.org/changeset/base/259407 > > > > Log: > > proc exit: don't take PROC_LOCK while freeing rlimits > > > > Code wishing to check rlimits of some process should check whether it > > is exiting first, which current consumers do. > > Does this measurably reduce contention? > No, this is just a cosmetic change I did while doing some other work with rlimits. It would use some more cosmetic work (e.g. no reason not to lim_free(p->plimit); p->p_limit = NULL) and maybe I'll get to that later unless this kind of stuff is unwanted. -- Mateusz Guzik