From owner-cvs-src@FreeBSD.ORG Tue Nov 11 12:09:34 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E103D16A4E5 for ; Tue, 11 Nov 2003 12:09:34 -0800 (PST) Received: from relay.pair.com (relay.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 814B443FE5 for ; Tue, 11 Nov 2003 12:09:30 -0800 (PST) (envelope-from silby@silby.com) Received: (qmail 13354 invoked from network); 11 Nov 2003 20:09:29 -0000 Received: from niwun.pair.com (HELO localhost) (209.68.2.70) by relay.pair.com with SMTP; 11 Nov 2003 20:09:29 -0000 X-pair-Authenticated: 209.68.2.70 Date: Tue, 11 Nov 2003 14:09:27 -0600 (CST) From: Mike Silbersack To: Jeffrey Hsu In-Reply-To: <200311111956.hABJuYoe011020@mta4.rcsntx.swbell.net> Message-ID: <20031111140440.V16061@odysseus.silby.com> References: <200311111956.hABJuYoe011020@mta4.rcsntx.swbell.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: sam@errno.com cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Peter Wemm cc: cvs-src@FreeBSD.org cc: Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?= cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Nov 2003 20:09:35 -0000 On Tue, 11 Nov 2003, Jeffrey Hsu wrote: > Asking nicely for a more verbose clarification of a commit message this > is too short is perfectly fine and reasonable. Demanding an immediate > backout without justification is an entirely different matter. It's > just plain bullying. > > Jeffrey Technically, your original change was correct, since syncache_respond turned out not to have complete locking... ... also technically, sam didn't back out your change, he switched the MPSAFEness to be dependent on the debug_mpsafenet flag, so that it would only be MPSAFE for those who took the risk... ... and Sam had some assertions and fixes in p4 which he was planning to commit to CVS, but hadn't gotten to yet... So, let's all just agree that things got a bit desynchronized and drop this, it's not worth our time to argue over a one line change. Mike "Silby" Silbersack