From nobody Wed Feb  1 16:40:37 2023
X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P6SMr3F9gz3cgPy
	for <dev-commits-src-main@mlmmj.nyi.freebsd.org>; Wed,  1 Feb 2023 16:40:40 +0000 (UTC)
	(envelope-from jrtc27@jrtc27.com)
Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4P6SMr0b2Qz3Hyr
	for <dev-commits-src-main@freebsd.org>; Wed,  1 Feb 2023 16:40:40 +0000 (UTC)
	(envelope-from jrtc27@jrtc27.com)
Authentication-Results: mx1.freebsd.org;
	none
Received: by mail-wm1-f51.google.com with SMTP id n28-20020a05600c3b9c00b003ddca7a2bcbso1933685wms.3
        for <dev-commits-src-main@freebsd.org>; Wed, 01 Feb 2023 08:40:40 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=to:references:message-id:content-transfer-encoding:cc:date
         :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=yh63ssaPQorriw9zVvpx1cgx9O0eIwZvjJdJEXSVrIw=;
        b=20seautLqf9JnwgrVHrv2ovE3m67gECskAww5tGzuft/CfHSXGhGcB7IGW8n0nDSBa
         VHSAhawnPFe8uWeIPHBPNg+Fa4BHKulTKABkk3AF/oX9FGVXRzfhenHd0N5kHP/AZHIJ
         rOkdAALw+RkTRewRk+Xvfr33FtfMSn6knd8F1E92GOez6VsXyP9QDD4BNO6j16FnWb7l
         XLWdQBNNjGhXhfwLaPR309WZP76n/Ms7zLSx0RlLPgS5MIQk6Vn6JaFnyJT7M2oMTf7N
         ZCKJIw9Pq06OrJu42EAzNuP2XYw/Kx8vd6YbFVlc9XIXw0jwEpgI6oG78Rk8sc+oT8Hy
         /LKg==
X-Gm-Message-State: AO0yUKVXmy3vpUo0hqlF9N4dHpYorwhMjcpXhjzt0vkMp806LT+a4KOH
	6Ba96ZdG6BC69XIC7P3OZpERlsBhybPkZM06PFUa1A==
X-Google-Smtp-Source: AK7set+cSP8z+8n5HexGrPZvKzIKud+n77Gt339H9yeJwJ9Nz3TEfExdz0G+raxLytMiYdPvaNBTJg==
X-Received: by 2002:a05:600c:3acc:b0:3dd:1ac1:2572 with SMTP id d12-20020a05600c3acc00b003dd1ac12572mr2964647wms.1.1675269638660;
        Wed, 01 Feb 2023 08:40:38 -0800 (PST)
Received: from smtpclient.apple (global-5-143.n-2.net.cam.ac.uk. [131.111.5.143])
        by smtp.gmail.com with ESMTPSA id bg21-20020a05600c3c9500b003db06493ee7sm2604521wmb.47.2023.02.01.08.40.38
        (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 01 Feb 2023 08:40:38 -0800 (PST)
Content-Type: text/plain;
	charset=utf-8
List-Id: Commit messages for the main branch of the src repository <dev-commits-src-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main
List-Help: <mailto:dev-commits-src-main+help@freebsd.org>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-main@freebsd.org
X-BeenThere: dev-commits-src-main@freebsd.org
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: git: 1e0853ee8403 - main - sys/kbio.h: support Unicode key codes
 in vt keymap files
From: Jessica Clarke <jrtc27@freebsd.org>
In-Reply-To: <202302011630.311GUmt1068106@gitrepo.freebsd.org>
Date: Wed, 1 Feb 2023 16:40:37 +0000
Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>,
 "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>,
 "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B18FC1EA-29B9-45A8-A666-35F975424256@freebsd.org>
References: <202302011630.311GUmt1068106@gitrepo.freebsd.org>
To: =?utf-8?Q?Stefan_E=C3=9Fer?= <se@FreeBSD.org>
X-Mailer: Apple Mail (2.3696.120.41.1.1)
X-Rspamd-Queue-Id: 4P6SMr0b2Qz3Hyr
X-Spamd-Bar: ----
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-ThisMailContainsUnwantedMimeParts: N

On 1 Feb 2023, at 16:30, Stefan E=C3=9Fer <se@FreeBSD.org> wrote:
>=20
> The branch main has been updated by se:
>=20
> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3D1e0853ee84031e4131a0b8cc8737696f=
199d3d4c
>=20
> commit 1e0853ee84031e4131a0b8cc8737696f199d3d4c
> Author:     Stefan E=C3=9Fer <se@FreeBSD.org>
> AuthorDate: 2023-02-01 16:24:18 +0000
> Commit:     Stefan E=C3=9Fer <se@FreeBSD.org>
> CommitDate: 2023-02-01 16:24:18 +0000
>=20
>    sys/kbio.h: support Unicode key codes in vt keymap files
>=20
>    Some keyboard definitions return Unicode characters that cannot be
>    represented in the 8 bits provided by an u_char.
>=20
>    Extend then width of the keycode entries to 16 bits to allow for =
all
>    keycodes currently defined in share/vt/keymaps/*,kbd.
>=20
>    Reported by:       yuri@aetern.org
>    MFC after:         3 days
> ---
> sys/sys/kbio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/sys/sys/kbio.h b/sys/sys/kbio.h
> index 7f17bda76c51..b0779f5ed114 100644
> --- a/sys/sys/kbio.h
> +++ b/sys/sys/kbio.h
> @@ -200,7 +200,7 @@ typedef struct okeymap okeymap_t;
>=20
> struct acc_t {
> 	u_char		accchar;
> -	u_char		map[NUM_ACCENTCHARS][2];
> +	u_short		map[NUM_ACCENTCHARS][2];

This breaks ABI for [GP]IO_DEADKEYMAP.

Jess

> };
>=20
> struct accentmap {