From owner-cvs-src@FreeBSD.ORG  Mon Jul 31 13:49:08 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 249FA16A4E0;
	Mon, 31 Jul 2006 13:49:08 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F112C43D62;
	Mon, 31 Jul 2006 13:49:06 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 0C83E46CD9;
	Mon, 31 Jul 2006 09:49:06 -0400 (EDT)
Date: Mon, 31 Jul 2006 14:49:05 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Gleb Smirnoff <glebius@FreeBSD.org>
In-Reply-To: <20060731131502.GS96644@FreeBSD.org>
Message-ID: <20060731144841.Y71432@fledge.watson.org>
References: <200607200357.k6K3vwg2039627@repoman.freebsd.org>
	<20060731131502.GS96644@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Pyun YongHyeon <yongari@FreeBSD.org>
Subject: Re: cvs commit: src/sys/dev/em if_em.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Jul 2006 13:49:08 -0000

On Mon, 31 Jul 2006, Gleb Smirnoff wrote:

> On Thu, Jul 20, 2006 at 03:57:58AM +0000, Pyun YongHyeon wrote:
> P> yongari     2006-07-20 03:57:58 UTC
> P>
> P>   FreeBSD src repository
> P>
> P>   Modified files:
> P>     sys/dev/em           if_em.c
> P>   Log:
> P>   Honor IFF_DRV_OACTIVE in em_start_locked().
>
> Isn't it better to shift this change to the em_start(), to avoid double 
> check of IFF_DRV_RUNNING? Or may be just merge em_start_locked() into the 
> em_start()?

Isn't em_start_locked() called from quite a few different places, including 
the interrupt handler, etc, where the mutex is already held?

Robert N M Watson
Computer Laboratory
University of Cambridge