From owner-freebsd-ports@FreeBSD.ORG Sat Jun 16 14:13:52 2012 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CE145106566C; Sat, 16 Jun 2012 14:13:52 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78]) by mx1.freebsd.org (Postfix) with ESMTP id 57CF98FC14; Sat, 16 Jun 2012 14:13:52 +0000 (UTC) Received: from seedling.black-earth.co.uk (seedling.black-earth.co.uk [81.187.76.163]) (authenticated bits=0) by smtp.infracaninophile.co.uk (8.14.5/8.14.5) with ESMTP id q5GEDcp4036559 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 16 Jun 2012 15:13:44 +0100 (BST) (envelope-from matthew@FreeBSD.org) X-DKIM: OpenDKIM Filter v2.5.2 smtp.infracaninophile.co.uk q5GEDcp4036559 Authentication-Results: smtp.infracaninophile.co.uk/q5GEDcp4036559; dkim=none (no signature); dkim-adsp=none Message-ID: <4FDC9488.2010509@FreeBSD.org> Date: Sat, 16 Jun 2012 15:13:28 +0100 From: Matthew Seaman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Chris Rees References: <4FD8AFEC.6070605@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.4.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigC4FBBC38A2AE410A7EF15968" X-Virus-Scanned: clamav-milter 0.97.4 at lucid-nonsense.infracaninophile.co.uk X-Virus-Status: Clean X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lucid-nonsense.infracaninophile.co.uk Cc: freebsd-ports Subject: Re: [CFT] UNIQUENAME patches X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2012 14:13:53 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC4FBBC38A2AE410A7EF15968 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 16/06/2012 14:18, Chris Rees wrote: > That's great-- though rather than patching colliding-only ports, can't > we just add the category to it? >=20 > .for cat in ${CATEGORIES} > UNIQUEPREFIX?=3D ${cat} > .endfor >=20 > (copying the code from PKGCATEGORY; might be better off moving the > PKGCATEGORY code up higher and just using that). Yes. I thought long and hard about doing that, but I opted not to for two reasons: 1) Using the port name + a uniqueprefix where necessary produces what is close to the minimal change required to give every port a unique name. The UNIQUENAME won't actually change for quite a lot of ports under my scheme. 2) As a way of future-proofing against reorganizations of the ports tree. What tends to happen is that a new category is invented and a number of ports are moved into it. My way should avoid changing the UNIQUENAME in the majority of cases. Remember that changing the UNIQUENAME changes where the record of the port options are stored, and either we annoy a lot of users by making them fill in a buch of dialogues all over again, or we have to invent some complicated mechanism copy the old options settings to the new directory. (Yes -- this sort of thing will occur with the changes as written. It can't be avoided entirely.) Plus I think it would be more natural and easier for maintainers and end-users to talk about (say) "phpmyadmin" rather than "databases-phpmyadmin." Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. PGP: http://www.infracaninophile.co.uk/pgpkey --------------enigC4FBBC38A2AE410A7EF15968 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/clJIACgkQ8Mjk52CukIzigQCfV8JlFWkVX1W8ptHUE1gtXozR VgMAnjjSCmDOIBbr2ZdxIvM1nhfS0z24 =p520 -----END PGP SIGNATURE----- --------------enigC4FBBC38A2AE410A7EF15968--