Date: Fri, 03 Feb 2023 19:22:49 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Neel Chauhan <nc@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: d8951a8d01aa - main - www/webkit2-gtk4: Update to 2.38.3 Message-ID: <bkma-hame-wny@FreeBSD.org> In-Reply-To: <202302031802.313I2Z43013827@gitrepo.freebsd.org> (Neel Chauhan's message of "Fri, 3 Feb 2023 18:02:35 GMT") References: <202302031802.313I2Z43013827@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Neel Chauhan <nc@FreeBSD.org> writes:
> # On Linux, use ELF GOT relocation specifiers.
> - $asm.putStr("#elif OS(LINUX)")
> -+ $asm.putStr("#elif OS(LINUX) || OS(FREEBSD)")
> ++ $asm.putStr("#elif OS(LINUX) || OS(OPENBSD)")
> $asm.puts "adrp #{operands[1].arm64Operand(:quad)}, :got:#{operands[0].asmLabel}"
> $asm.puts "ldr #{operands[1].arm64Operand(:quad)}, [#{operands[1].arm64Operand(:quad)}, :got_lo12:#{operands[0].asmLabel}]"
Unless OS(OPENBSD) works on FreeBSD this may break build on aarch64.
See also https://cgit.freebsd.org/ports/commit/?id=853f7cd1cbc8
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bkma-hame-wny>