From owner-svn-src-head@freebsd.org Thu Feb 18 23:57:47 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AC260AACAAE for ; Thu, 18 Feb 2016 23:57:47 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5DF76AD for ; Thu, 18 Feb 2016 23:57:47 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: by mail-wm0-x234.google.com with SMTP id g62so52637156wme.1 for ; Thu, 18 Feb 2016 15:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sippysoft-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:date:message-id:subject:from:to:cc:content-type; bh=zWCBF49i/NM8fxpLeReKaPdBt1KbXQorVj88SfFg5rc=; b=H5dRmUGZUd2pgSUU3AnUNeOA7PngcgoAAl8XiX8uLYDqsTQ7dpmxArGWhz2IHGu4dp 45d9wbcpABEu8NXt6zveTLGHG7Rmg+Tdz2xSXhrJshWcjDevOoAH/I2PAi+ySigAZGu2 k+u9URSVI5CzyLguVQ2X/QpONljs2FjkOog00E92gAFThJFuBb8JzAa7HDbfTYIDhV6M GI23TkKJTE9zDP8JaAoeLloJUxOYm0uEiPo7Vaes4s/T1jYW6N69B+kPZwevibR1QYiE ZRJ2cm49BlGPqJZDUYckvDsupwC3iTgqFiNTzHo0nONVTIB8zxJHsNGJs6aDcAfrUQ/5 xhZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:date:message-id:subject:from :to:cc:content-type; bh=zWCBF49i/NM8fxpLeReKaPdBt1KbXQorVj88SfFg5rc=; b=lOv8Plxj5HLN9sMB553n0iy+OnM1qT1WQNUFmJmanIFyHcftGSNXGzXylLshxN2u9p R30xzlnsWfFp0Je+KbNUZPAK+ghQQ1QIrNKUq8RTE/y00PmVx1rOOsh3luyPwBPizHx+ fDYF2NcdQS1bjm+BEChP6A986U0XDGlR2bzt+NCFiFLidp0EMVW2K+wtUNHJHf7u0KgR cbd3IN1YTQBOKy9gP3QMA0Bh/4ZmmYKXLIxtatqNLszFeKf4lnxan0Lv4z2dvibx1z8o cQZ16xJdmqgI//7drVdTkSyxmWs19Gmae1WhrrufnPx7oGj4Gl3HqAxpSt3VOo7E5KII ubsA== X-Gm-Message-State: AG10YOTu2GpdTE3R7uikSuotBVlyiz2NirG+gHuAgZeEW88NhcxYnXlB2x9OcAKSjM/SduFHjca5eh27FukfiINh MIME-Version: 1.0 X-Received: by 10.194.111.229 with SMTP id il5mr8319917wjb.82.1455839865837; Thu, 18 Feb 2016 15:57:45 -0800 (PST) Sender: sobomax@sippysoft.com Received: by 10.27.218.12 with HTTP; Thu, 18 Feb 2016 15:57:45 -0800 (PST) Date: Thu, 18 Feb 2016 15:57:45 -0800 X-Google-Sender-Auth: dMirU71Plcqh1oDSYDqlyoYqVwQ Message-ID: Subject: Re: svn commit: r229537 - in head/sys: conf geom/uncompress modules/geom/geom_uncompress From: Maxim Sobolev To: ray@FreeBSD.org, Adrian Chadd Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2016 23:57:47 -0000 Aleksandr, Adrian, I know it's 3 years later, but I really don't know why it's been done this way. Take a GEOM module and associated usr.bin utility, copy it verbatim add few lines of code and re-add that as a new module seems like just laziness and attempt to avoid doing extra work on making unified code. The same goes for the mkulzma, which is almost 1:1 copy of the mkuzip. Now people are merging back and forth and I've just spent few days testing some rather major rework of geom_uzip / mkuzip code not even realizing that there is its evil twin in the tree. :( https://reviews.freebsd.org/D5333 I suggest functionality from both geom_uncompress / mkulzma are folded now back into geom_uzip / mkuzip and geom_uncompress / mkulzma are nuked afterwards. Thanks! > Author: ray > Date: Wed Jan 4 23:39:11 2012 > New Revision: 229537 > URL: http://svn.freebsd.org/changeset/base/229537 > Log: > GEOM_UNCOMPRESS module, can be used with uzip images and with new ulzma > images. > Approved by: adrian (mentor) > Added: > head/sys/geom/uncompress/ > head/sys/geom/uncompress/g_uncompress.c (contents, props changed) > head/sys/modules/geom/geom_uncompress/ > head/sys/modules/geom/geom_uncompress/Makefile (contents, props changed) > Modified: > head/sys/conf/files > head/sys/conf/options