Date: Fri, 01 Feb 2008 18:13:18 +0200 From: Andriy Gapon <avg@icyb.net.ua> To: freebsd-acpi@freebsd.org Subject: no way to force AC state if current one is none Message-ID: <47A3451E.5060803@icyb.net.ua>
next in thread | raw e-mail | index | archive | help
I noticed that I can force AC state change via sysctl if current state
is none/-1.
acpi_tz_monitor() has the following lines:
/* Handle user override of active mode */
if (sc->tz_requested != TZ_ACTIVE_NONE && sc->tz_requested < newactive)
newactive = sc->tz_requested;
If say tz_requested is 1, but auto-calculated newactive is -1 (none),
then this check fails and tz_requested is ignored.
It seems there should be a check that newactive is not -1:
if (sc->tz_requested != TZ_ACTIVE_NONE && (newactive == TZ_ACTIVE_NONE
|| sc->tz_requested < newactive))
What do you think ?
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47A3451E.5060803>