From owner-freebsd-bugs@FreeBSD.ORG  Mon Mar 25 14:40:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 4E131CE6
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Mon, 25 Mar 2013 14:40:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 27B16382
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Mon, 25 Mar 2013 14:40:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2PEe14S050312
 for <freebsd-bugs@freefall.freebsd.org>; Mon, 25 Mar 2013 14:40:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2PEe05F050311;
 Mon, 25 Mar 2013 14:40:00 GMT (envelope-from gnats)
Date: Mon, 25 Mar 2013 14:40:00 GMT
Message-Id: <201303251440.r2PEe05F050311@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: kern/172166: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Mar 2013 14:40:01 -0000

The following reply was made to PR kern/172166; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/172166: commit references a PR
Date: Mon, 25 Mar 2013 14:30:42 +0000 (UTC)

 Author: melifaro
 Date: Mon Mar 25 14:30:34 2013
 New Revision: 248705
 URL: http://svnweb.freebsd.org/changeset/base/248705
 
 Log:
   Unlock IPMI sc while performing requests via KCS and SMIC interfaces.
   It is already done in SSIF interface code.
   This reduces contention/spinning reported by many users.
   
   PR:		kern/172166
   Submitted by:	Eric van Gyzen <eric at vangyzen.net>
   MFC after:	2 weeks
 
 Modified:
   head/sys/dev/ipmi/ipmi_kcs.c
   head/sys/dev/ipmi/ipmi_smic.c
 
 Modified: head/sys/dev/ipmi/ipmi_kcs.c
 ==============================================================================
 --- head/sys/dev/ipmi/ipmi_kcs.c	Mon Mar 25 13:58:17 2013	(r248704)
 +++ head/sys/dev/ipmi/ipmi_kcs.c	Mon Mar 25 14:30:34 2013	(r248705)
 @@ -456,6 +456,7 @@ kcs_loop(void *arg)
  
  	IPMI_LOCK(sc);
  	while ((req = ipmi_dequeue_request(sc)) != NULL) {
 +		IPMI_UNLOCK(sc);
  		ok = 0;
  		for (i = 0; i < 3 && !ok; i++)
  			ok = kcs_polled_request(sc, req);
 @@ -463,6 +464,7 @@ kcs_loop(void *arg)
  			req->ir_error = 0;
  		else
  			req->ir_error = EIO;
 +		IPMI_LOCK(sc);
  		ipmi_complete_request(sc, req);
  	}
  	IPMI_UNLOCK(sc);
 
 Modified: head/sys/dev/ipmi/ipmi_smic.c
 ==============================================================================
 --- head/sys/dev/ipmi/ipmi_smic.c	Mon Mar 25 13:58:17 2013	(r248704)
 +++ head/sys/dev/ipmi/ipmi_smic.c	Mon Mar 25 14:30:34 2013	(r248705)
 @@ -362,6 +362,7 @@ smic_loop(void *arg)
  
  	IPMI_LOCK(sc);
  	while ((req = ipmi_dequeue_request(sc)) != NULL) {
 +		IPMI_UNLOCK(sc);
  		ok = 0;
  		for (i = 0; i < 3 && !ok; i++)
  			ok = smic_polled_request(sc, req);
 @@ -369,6 +370,7 @@ smic_loop(void *arg)
  			req->ir_error = 0;
  		else
  			req->ir_error = EIO;
 +		IPMI_LOCK(sc);
  		ipmi_complete_request(sc, req);
  	}
  	IPMI_UNLOCK(sc);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"