From owner-svn-src-head@FreeBSD.ORG Sun Jul 15 16:23:53 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 87C261065674; Sun, 15 Jul 2012 16:23:53 +0000 (UTC) (envelope-from SRS0=dIDz=FQ=FreeBSD.org=brueffer@srs.kundenserver.de) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.10]) by mx1.freebsd.org (Postfix) with ESMTP id EDCC28FC0C; Sun, 15 Jul 2012 16:23:52 +0000 (UTC) Received: from hd948344f.sedadby.dyn.perspektivbredband.net (hd948344f.sedadby.dyn.perspektivbredband.net [217.72.52.79]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0Lo5Nc-1TW71538My-00gEfU; Sun, 15 Jul 2012 18:23:52 +0200 Message-ID: <5002EE96.2060104@FreeBSD.org> Date: Sun, 15 Jul 2012 18:23:50 +0200 From: Christian Brueffer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Mateusz Guzik References: <201207151550.q6FFoCMo056166@svn.freebsd.org> <20120715160410.GA22600@dft-labs.eu> In-Reply-To: <20120715160410.GA22600@dft-labs.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:ntJrFCmH4SHkZS6Z2BSj11SztBHxiAO86bgNnpfhIN9 pYJ4ASILDxf05nCgY/CCuh+QpvGY0YNMgxT1h8xN3EjXjRFnku 8XOD+q+jWAOergx7Bei+yn3dznjYs7gMQd5BcZhjxi5Yt9DI+7 tEX/1wyi0oclqjhjMUl+mJvjEUEjown+9gnqeqIoEp1tsTli5E UjoorYUSV41R+0UWIN12HrgSbX6U+DTINRjINcZ6oIvxyk9Uip E2Hw1kd5a6ZRgtDJPfTTi2n7bGDodALgmdrmFoaN+ewPABvlyl 9WZuSU2UDZvi28KqiEpN13zLHMZ3ATqgdgOBDX0W5m4kDI4QOa v/QZMUMTwSx/BtClQfDJ+rwKnYOHSRYzWSh0rf2VlayjbNOsHp LeaheWd4O2enQ== Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r238491 - head/sys/fs/smbfs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2012 16:23:53 -0000 On 7/15/12 18:04 , Mateusz Guzik wrote: > On Sun, Jul 15, 2012 at 03:50:12PM +0000, Christian Brueffer wrote: >> Author: brueffer >> Date: Sun Jul 15 15:50:12 2012 >> New Revision: 238491 >> URL: http://svn.freebsd.org/changeset/base/238491 >> >> Log: >> Save a bzero() by using M_ZERO. >> >> Obtained from: Dragonfly BSD (change 4faaf07c3d7ddd120deed007370aaf4d90b72ebb) >> MFC after: 2 weeks >> >> Modified: >> head/sys/fs/smbfs/smbfs_node.c >> >> Modified: head/sys/fs/smbfs/smbfs_node.c >> ============================================================================== >> --- head/sys/fs/smbfs/smbfs_node.c Sun Jul 15 15:23:31 2012 (r238490) >> +++ head/sys/fs/smbfs/smbfs_node.c Sun Jul 15 15:50:12 2012 (r238491) >> @@ -223,7 +223,7 @@ loop: >> if (fap == NULL) >> return ENOENT; >> >> - np = malloc(sizeof *np, M_SMBNODE, M_WAITOK); >> + np = malloc(sizeof *np, M_SMBNODE, M_WAITOK | M_ZERO); >> error = getnewvnode("smbfs", mp, &smbfs_vnodeops, &vp); >> if (error) { >> free(np, M_SMBNODE); >> @@ -235,7 +235,6 @@ loop: >> return (error); >> } >> vp->v_type = fap->fa_attr & SMB_FA_DIR ? VDIR : VREG; >> - bzero(np, sizeof(*np)); >> vp->v_data = np; >> np->n_vnode = vp; >> np->n_mount = VFSTOSMBFS(mp); > > How about moving this malloc right before np is actually used? > While here some style(9) fixes. > > http://people.freebsd.org/~mjg/patches/smbfs_node-malloc.patch > > Completely untested (even compile-time); I guess the idea is clear. :) > Looks good to me. Want to give your shiny new commit bit a spin? ;-) If not, I'll handle it. Chris