From owner-svn-src-head@FreeBSD.ORG Sat Nov 1 16:47:21 2008 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F255106568C; Sat, 1 Nov 2008 16:47:21 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id DF1C18FC14; Sat, 1 Nov 2008 16:47:20 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id mA1GisrU015627; Sat, 1 Nov 2008 10:44:54 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 01 Nov 2008 10:46:07 -0600 (MDT) Message-Id: <20081101.104607.1844477909.imp@bsdimp.com> To: kostikbel@gmail.com From: "M. Warner Losh" In-Reply-To: <20081101103025.GU18100@deviant.kiev.zoral.com.ua> References: <200810312324.m9VNOE88093395@svn.freebsd.org> <20081101103025.GU18100@deviant.kiev.zoral.com.ua> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r184515 - in head/sys: conf modules/rl pci X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Nov 2008 16:47:21 -0000 In message: <20081101103025.GU18100@deviant.kiev.zoral.com.ua> Kostik Belousov writes: : On Fri, Oct 31, 2008 at 11:24:14PM +0000, Warner Losh wrote: : > Author: imp : > Date: Fri Oct 31 23:24:13 2008 : > New Revision: 184515 : > URL: http://svn.freebsd.org/changeset/base/184515 : > : > Log: : > Add RL_TWISTER_ENABLE option. This enables the magic bits to do long : > cable tuning. This has helped in some installations for hardware : > deployed by a former employer. Made optional because the lists aren't : > full of complaints about these cards... even when they were wildly : > popular. : > : > Reviewed by: attilio@, jhb@, trhodes@ (all an older version of the patch) : > : > Modified: : > head/sys/conf/options : > head/sys/modules/rl/Makefile : > head/sys/pci/if_rl.c : > head/sys/pci/if_rlreg.h : > : > Modified: head/sys/conf/options : > ============================================================================== : > --- head/sys/conf/options Fri Oct 31 18:40:35 2008 (r184514) : > +++ head/sys/conf/options Fri Oct 31 23:24:13 2008 (r184515) : > @@ -672,6 +672,9 @@ ED_SIC opt_ed.h : > # bce driver : > BCE_DEBUG opt_bce.h : > : > +# rl driver : > +RL_TWISTER_ENABLE opt_rl.h : Would it make sense to compile it unconditionally, but enable by a sysctl : or loader knob ? That's a good idea. Given the level of problems here, and my lack of time, I'll leave it to someone else I think. Warner