From owner-freebsd-current@FreeBSD.ORG  Mon Jan 23 08:12:49 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BE275106566C
	for <freebsd-current@freebsd.org>; Mon, 23 Jan 2012 08:12:49 +0000 (UTC)
	(envelope-from okuno.kohji@jp.panasonic.com)
Received: from smtp.mei.co.jp (smtp.mei.co.jp [133.183.100.20])
	by mx1.freebsd.org (Postfix) with ESMTP id 6846B8FC0A
	for <freebsd-current@freebsd.org>; Mon, 23 Jan 2012 08:12:49 +0000 (UTC)
Received: from mail-gw.jp.panasonic.com ([157.8.1.157])
	by smtp.mei.co.jp (8.12.11.20060614/3.7W/kc-maile13) with ESMTP id
	q0N8ClI2000753
	for <freebsd-current@freebsd.org>; Mon, 23 Jan 2012 17:12:47 +0900 (JST)
Received: from epochmail.jp.panasonic.com ([157.8.1.130])
	by mail.jp.panasonic.com (8.11.6p2/3.7W/kc-maili14) with ESMTP id
	q0N8Cl513425
	for <freebsd-current@freebsd.org>; Mon, 23 Jan 2012 17:12:47 +0900
Received: by epochmail.jp.panasonic.com (8.12.11.20060308/3.7W/lomi16) id
	q0N8Clmk020317
	for freebsd-current@freebsd.org; Mon, 23 Jan 2012 17:12:47 +0900
Received: from localhost
	by lomi16.jp.panasonic.com (8.12.11.20060308/3.7W) with ESMTP id
	q0N8ClxL020273
	for <freebsd-current@freebsd.org>; Mon, 23 Jan 2012 17:12:47 +0900
Date: Mon, 23 Jan 2012 17:12:46 +0900 (JST)
Message-Id: <20120123.171246.321689433999174416.okuno.kohji@jp.panasonic.com>
To: freebsd-current@freebsd.org
From: Kohji Okuno <okuno.kohji@jp.panasonic.com>
Organization: Panasonic Corporation
X-Mailer: Mew version 6.4 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Is UPS_PORT_POWER wrong?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2012 08:12:49 -0000

Hi HPS,

I think that UPS_PORT_POWER and UPS_PORT_LINK_STATE overlap.
And, in xhci.c you set UPS_PORT_POWER as folows.

When UPS_PORT_POWER is set, UPS_PORT_LINK_STATE_GET() macro will
return incorrect value.

                if (v & XHCI_PS_PP) {
                        /*
                         * The USB 3.0 RH is using the
                         * USB 2.0's power bit
                         */
                        i |= UPS_PORT_POWER;
                }

Regards,
 Kohji Okuno