From owner-freebsd-current Fri Jun 28 8:40:25 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CFE1437B401; Fri, 28 Jun 2002 08:40:19 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1114743E09; Fri, 28 Jun 2002 08:40:19 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g5SFc76I004382; Fri, 28 Jun 2002 17:38:09 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Mike Barcroft Cc: Robert Drehmel , current@FreeBSD.ORG, robert@FreeBSD.ORG Subject: Re: changing 'struct utmp' In-Reply-To: Your message of "Fri, 28 Jun 2002 11:34:54 EDT." <20020628113454.B34516@espresso.q9media.com> Date: Fri, 28 Jun 2002 17:38:07 +0200 Message-ID: <4381.1025278687@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020628113454.B34516@espresso.q9media.com>, Mike Barcroft writes: >Robert Drehmel writes: >> While trying to fix the bug described in a problem report about >> 'w -n', and finding out that it is somewhat broken*, I came to >> the conclusion that our 'struct utmp' is too limiting. >> >> I would like to modernize it as follows: >> >> #define UT_USERSIZE 16 >> #define UT_LINESIZE 8 >> #define UT_HOSTSIZE 18 /* increase by two bytes */ > >I think it might be a wise idea to make UT_HOSTSIZE much larger. >Currently, it isn't even large enough to hold an IPv6 address. really guys, we need to do this right. The entire "line-number from /etc/ttys is index into file" concept sucks. Fixed sized records suck badly. Please, if you're going to do it, do it right. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message