From owner-cvs-all Fri Jan 3 2:40:16 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D3A7537B401; Fri, 3 Jan 2003 02:40:14 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 042A043EC5; Fri, 3 Jan 2003 02:40:14 -0800 (PST) (envelope-from phk@freebsd.org) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id h03AeAF4010908; Fri, 3 Jan 2003 11:40:10 +0100 (CET) (envelope-from phk@freebsd.org) To: Bruce Evans Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys _mutex.h From: phk@freebsd.org In-Reply-To: Your message of "Fri, 03 Jan 2003 21:32:48 +1100." <20030103212617.K2888-100000@gamplex.bde.org> Date: Fri, 03 Jan 2003 11:40:10 +0100 Message-ID: <10907.1041590410@critter.freebsd.dk> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20030103212617.K2888-100000@gamplex.bde.org>, Bruce Evans writes: >On Thu, 2 Jan 2003, Poul-Henning Kamp wrote: > >> phk 2003/01/02 11:58:03 PST >> >> Modified files: (Branch: RELENG_5_0) >> sys/sys _mutex.h >> Log: >> MFC: Conditionalize 16 bytes of struct mutex on MUTEX_PROFILING >> >> Approved by: re@ >> >> Revision Changes Path >> 1.8.2.1 +6 -1 src/sys/sys/_mutex.h > >Please back this out. It is contentious even in -current. Even its >misleading comment hasn't been fixed. I'll await re@'s decision. It is necessary to prevent -current and 5.0-RELENG machines from running out of kmem_map space and as I read John, that takes precedence. I agree that we should probably fix the comment and remove MUTEX_PROFILING from conf/options to prevent unintended use. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message