From owner-svn-ports-head@freebsd.org  Sun Jun 11 13:54:25 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 397EBD87879;
 Sun, 11 Jun 2017 13:54:25 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1B006663EA;
 Sun, 11 Jun 2017 13:54:25 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 4242A189B2; Sun, 11 Jun 2017 13:54:24 +0000 (UTC)
Date: Sun, 11 Jun 2017 13:54:24 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Wen Heping <wen@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r443389 - in head/audio/shairport: . files
Message-ID: <20170611135424.GB15068@FreeBSD.org>
References: <201706111346.v5BDkflQ008975@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201706111346.v5BDkflQ008975@repo.freebsd.org>
User-Agent: Mutt/1.8.2 (2017-04-18)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Jun 2017 13:54:25 -0000

On Sun, Jun 11, 2017 at 01:46:41PM +0000, Wen Heping wrote:
> New Revision: 443389
> URL: https://svnweb.freebsd.org/changeset/ports/443389
> 
> Log:
>   - Update to 1.1.1
>   
>   PR:		194153
>   Submitted by:	swills@
>   Approved by:	maintainer(timeout, > 2 years)

It would be nice to provide more elaborate commit message.

> ...
> -RUN_DEPENDS=	p5-MIME-Base64>=0:converters/p5-MIME-Base64 \
> -		p5-Getopt-Long>=0:devel/p5-Getopt-Long \
> -		p5-URI>=0:net/p5-URI \
> -		p5-Crypt-OpenSSL-RSA>=0:security/p5-Crypt-OpenSSL-RSA \
> -		p5-Digest-MD5>=0:security/p5-Digest-MD5 \
> -		p5-HTTP-Message>=0:www/p5-HTTP-Message \
> -		avahi-publish-service:net/avahi-app
> +RUN_DEPENDS=	avahi-publish-service:net/avahi-app

So why those p5-* deps are no longer needed?

> +do-configure:
> +	cd ${WRKSRC} ; ./configure

What's wrong with our default configure target?

> +	cd ${WRKSRC} ; ${GMAKE} PREFIX=${STAGEDIR}${PREFIX} install

I believe MAKE_CMD should've been used here instead; also ``-C ${WRKSRC}''
would've saved you the trouble of explicit chdir.  Then again: what was
wrong with our default install target which essentially does the same?

./danfe