Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 5 Jun 2011 22:36:30 +0000 (UTC)
From:      Kirk McKusick <mckusick@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r222724 - head/sys/ufs/ffs
Message-ID:  <201106052236.p55MaU2L000377@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mckusick
Date: Sun Jun  5 22:36:30 2011
New Revision: 222724
URL: http://svn.freebsd.org/changeset/base/222724

Log:
  Grammer fix in comment.
  
  Eliminate one (of several) possible conflicting buffer locks when
  trying to reclaim blocks. Rest of fix to be incorporated as part
  of SUJ update by jeff.
  
  Pointed out by: Kostik Belousov

Modified:
  head/sys/ufs/ffs/ffs_alloc.c

Modified: head/sys/ufs/ffs/ffs_alloc.c
==============================================================================
--- head/sys/ufs/ffs/ffs_alloc.c	Sun Jun  5 21:01:41 2011	(r222723)
+++ head/sys/ufs/ffs/ffs_alloc.c	Sun Jun  5 22:36:30 2011	(r222724)
@@ -420,13 +420,13 @@ nospace:
 	 */
 	if (reclaimed == 0) {
 		reclaimed = 1;
-		softdep_request_cleanup(fs, vp, cred, FLUSH_BLOCKS_WAIT);
 		UFS_UNLOCK(ump);
 		if (bp) {
 			brelse(bp);
 			bp = NULL;
 		}
 		UFS_LOCK(ump);
+		softdep_request_cleanup(fs, vp, cred, FLUSH_BLOCKS_WAIT);
 		goto retry;
 	}
 	UFS_UNLOCK(ump);
@@ -2356,8 +2356,8 @@ ffs_fserr(fs, inum, cp)
  *	specified inode by the specified amount. Under normal
  *	operation the count should always go down. Decrementing
  *	the count to zero will cause the inode to be freed.
- * adjblkcnt(inode, amt) - adjust the number of blocks used to
- *	by the specifed amount.
+ * adjblkcnt(inode, amt) - adjust the number of blocks used by the
+ *	inode by the specified amount.
  * adjndir, adjbfree, adjifree, adjffree, adjnumclusters(amt) -
  *	adjust the superblock summary.
  * freedirs(inode, count) - directory inodes [inode..inode + count - 1]



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201106052236.p55MaU2L000377>