Date: Thu, 12 Jan 2012 15:13:45 -0700 From: "Kenneth D. Merry" <ken@freebsd.org> To: Dan McGregor <danismostlikely@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: ctlstat not building with clang Message-ID: <20120112221345.GA10593@nargothrond.kdm.org> In-Reply-To: <CACS%2B7ZT5Mi=v41cpE9ZP0hjiHA1THwZFn-jZfTqHL1O4N-8beg@mail.gmail.com> References: <CACS%2B7ZT5Mi=v41cpE9ZP0hjiHA1THwZFn-jZfTqHL1O4N-8beg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 12, 2012 at 14:59:11 -0600, Dan McGregor wrote: > Building world with clang now (as of r229997) no longer compiles because > ctlstat was imported into the tree. The error is: > > clang -O2 -pipe -I/usr/src/usr.bin/ctlstat/../../sys -std=gnu99 > -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W > -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes > -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow > -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs > -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c > /usr/src/usr.bin/ctlstat/ctlstat.c > /usr/src/usr.bin/ctlstat/ctlstat.c:149:35: error: format string is not a > string literal (potentially insecure) > [-Werror,-Wformat-security] > fprintf(error ? stderr : stdout, ctlstat_usage); > ^~~~~~~~~~~~~ > 1 error generated. > *** Error code 1 > > Stop in /usr/src/usr.bin/ctlstat > > How do people feel about the attached patch that turns a call to fprintf to > fputs? Looks fine, I just committed it. Thanks, Ken -- Kenneth Merry ken@FreeBSD.ORG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120112221345.GA10593>