From owner-cvs-all Sat Dec 28 14:17:31 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CBB2537B401; Sat, 28 Dec 2002 14:17:29 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A2C943EB2; Sat, 28 Dec 2002 14:17:29 -0800 (PST) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id gBSMHTfh050346; Sat, 28 Dec 2002 14:17:29 -0800 (PST) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id gBSMHTRJ050345; Sat, 28 Dec 2002 14:17:29 -0800 (PST) Message-Id: <200212282217.gBSMHTRJ050345@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 28 Dec 2002 14:17:29 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/sys _iovec.h socket.h uio.h X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG phk 2002/12/28 14:17:29 PST Modified files: sys/sys socket.h uio.h Added files: sys/sys _iovec.h Log: It is bad style to define the same structure in multiple header files which might be included together. Things like debuggers and lint-like programs get their knickers in a twist (rightly so one might add) when they find different locations for the same named struct depending on which .h file were included first. This is a stellar example of Very Bad Thinking on the part of the standards dudes who wrote that both sys/uio.h and sys/socket.h should define struct iovec the same way. Fix this by putting struct iovec into its own miniature sys/_iovec.h file and #include that from sys/socket.h and sys/uio.h. Sensible people could just put iovec into sys/_types.h but there is probably some standard or other which will be violated if we did something that horrible. Revision Changes Path 1.1 +45 -0 src/sys/sys/_iovec.h (new) 1.70 +1 -8 src/sys/sys/socket.h 1.24 +1 -8 src/sys/sys/uio.h To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message