From owner-svn-src-head@freebsd.org Sun Mar 26 14:43:28 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9DA3D1E517; Sun, 26 Mar 2017 14:43:28 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 381AA1F24; Sun, 26 Mar 2017 14:43:27 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from hermann ([78.52.132.127]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MhiPD-1cVEp112t1-00Mwx4; Sun, 26 Mar 2017 16:43:20 +0200 Date: Sun, 26 Mar 2017 16:43:18 +0200 From: "Hartmann, O." To: Andriy Voskoboinyk Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r315981 - head/sys/dev/iwn Message-ID: <20170326164309.759fc5b9@hermann> In-Reply-To: <201703260910.v2Q9A26Z081833@repo.freebsd.org> References: <201703260910.v2Q9A26Z081833@repo.freebsd.org> Organization: walstatt.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:5vhWXp6TtXknNrarH+OicNk2VELzxyozLSr92IM4wwxfwkMYHnu ecXSJ/piTsaM7uq5q2oGegftW3kG8VHUjtYj14524TqvrQaMQMNSQBVLDnjRw7ec4UAtnDD 81rKXGEWG+UqvYpruW0XzrJI4OQGOpw1jSPlmYUPNe2ugIR8bpLnehnWv7d5p8suowbZHB3 MYaD8XOPHFlbyZ2uW4hSQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:5cDFssN/zzw=:KNsuVid3O9QmS15FGuX8L3 oobpnmGB17RWXOCudLw15Tx61j1VqHAiLms5Y+jvbb2mAYehXn96Z0xc5lBCqlylpj4/YR8NA dzk6S0vfB8Zen9yGb9tUG2i3P6/oiXWw3esVqV8PX2Uid8govv2nzTqSk5Zh6jQKcltrtKkNm U7UATf2WkY/eJmSUUOp7DY1niDIzco5J1qYzAuc6hTT68c9mCnO470zM8TwaxanLNUNZAQyjw xqa9JL3vM7TXfISPH0eOC3hOfiV1QLfQ9cqEQFQPkclSgqsMLSACPWqh3pFQy0IGRGeLH42ux N0ZoUgjbsXtfvNKif9wHVc3qddRb2TvWi2bAx3s6oFRu6gXUQKnYjZxDgY71eh/PRsc6WVMWh 7mmGuCMfNRGtLWPMgZEzVOalAgsakLnUWwKFlqOei9tJzUP1SxHIXB/+aEE5sXLRVUWgaIis7 sm0T1bNnVAUNo+tgyMd7zFMPNKc41KjFLLV3bAh4dL2qWq0K3uXj3qTaAhYYnXviPlXptox9/ Fg7A1jMHnckob90uUVU5USy8HDaYWFlGCaLrFUYDtcOukOp8/tVbBzigsBFCT3Unhf3Y8CTGO xAFEjo/5mJT/OoWICC3CHrO98Yhj8mCseVN6lhk4nLy396CUw+xxS/lJy/zrt6+KfNeXlbXpF H3IsL21xt7PbSSYo2gguDN9mc9BMIS7ONWCry1FqW0hr7gbFHmA5pwd96tMw8ACMgQ9Q4eknE IAPjeZEgDajdEmvkYTAKTGFH2Qosp9wSBwecuFGRnl404OrlkYl8XV0asbutoWVZcyO1+pWuW 0t429ft X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Mar 2017 14:43:28 -0000 On Sun, 26 Mar 2017 09:10:02 +0000 (UTC) Andriy Voskoboinyk wrote: > Author: avos > Date: Sun Mar 26 09:10:01 2017 > New Revision: 315981 > URL: https://svnweb.freebsd.org/changeset/base/315981 > > Log: > iwn: omit unneeded bus_dmamap_sync() calls when compiled without > 'options IWN_DEBUG' > > Modified: > head/sys/dev/iwn/if_iwn.c > > Modified: head/sys/dev/iwn/if_iwn.c > ============================================================================== > --- head/sys/dev/iwn/if_iwn.c Sun Mar 26 08:54:08 2017 > (r315980) +++ head/sys/dev/iwn/if_iwn.c Sun Mar 26 09:10:01 > 2017 (r315981) @@ -3944,6 +3944,7 @@ iwn_notif_intr(struct > iwn_softc *sc) sc->errptr = le32toh(uc->errptr); > break; > } > +#ifdef IWN_DEBUG > case IWN_STATE_CHANGED: > { > /* > @@ -3953,27 +3954,26 @@ iwn_notif_intr(struct iwn_softc *sc) > */ > bus_dmamap_sync(sc->rxq.data_dmat, data->map, > BUS_DMASYNC_POSTREAD); > -#ifdef IWN_DEBUG > + > uint32_t *status = (uint32_t *)(desc + 1); > DPRINTF(sc, IWN_DEBUG_INTR | IWN_DEBUG_STATE, > "state changed to %x\n", > le32toh(*status)); > -#endif > break; > } > case IWN_START_SCAN: > { > bus_dmamap_sync(sc->rxq.data_dmat, data->map, > BUS_DMASYNC_POSTREAD); > -#ifdef IWN_DEBUG > + > struct iwn_start_scan *scan = > (struct iwn_start_scan *)(desc + 1); > DPRINTF(sc, IWN_DEBUG_ANY, > "%s: scanning channel %d status %x\n", > __func__, scan->chan, > le32toh(scan->status)); -#endif > break; > } > +#endif > case IWN_STOP_SCAN: > { > bus_dmamap_sync(sc->rxq.data_dmat, data->map, > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to > "svn-src-head-unsubscribe@freebsd.org" It seems when iwm is configured in a kernel without debugging enabled, builkernel failsas shown below: [...] -------------------------------------------------------------- >>> stage 3.1: building everything -------------------------------------------------------------- cd /usr/obj/usr/src/sys/HERMANN; COMPILER_VERSION=40000 COMPILER_TYPE=clang COMPILER_FREEBSD_VERSION=1200006 MAKEOBJDIRPREFIX=/usr/obj MACHINE_ARCH=amd64 MACHINE=amd64 CPUTYPE=native BUILD_TOOLS_META=.NOMETA_CMP GROFF_BIN_PATH=/usr/obj/usr/src/tmp/legacy/usr/bin GROFF_FONT_PATH=/usr/obj/usr/src/tmp/legacy/usr/share/groff_font GROFF_TMAC_PATH=/usr/obj/usr/src/tmp/legacy/usr/share/tmac CC="cc -target x86_64-unknown-freebsd12.0 --sysroot=/usr/obj/usr/src/tmp -B/usr/obj/usr/src/tmp/usr/bin" CXX="c++ -target x86_64-unknown-freebsd12.0 --sysroot=/usr/obj/usr/src/tmp -B/usr/obj/usr/src/tmp/usr/bin" CPP="cpp -target x86_64-unknown-freebsd12.0 --sysroot=/usr/obj/usr/src/tmp -B/usr/obj/usr/src/tmp/usr/bin" AS="as" AR="ar" LD="ld" LLVM_LINK="" NM=nm OBJCOPY="objcopy" RANLIB=ranlib STRINGS= SIZE="size" INSTALL="sh /usr/src/tools/install.sh" PATH=/usr/obj/usr/src/tmp/legacy/usr/sbin:/usr/obj/usr/src/tmp/legacy/usr/bin:/usr/obj/usr/src/tmp/legacy/bin:/usr/obj/usr/src/tmp/usr/sbin:/usr/obj/usr/src/tmp/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin make -m /usr/src/share/mk KERNEL=kernel all -DNO_MODULES_OBJ Building /usr/obj/usr/src/sys/HERMANN/if_iwm_scan.o /usr/src/sys/dev/iwm/if_iwm_scan.c:224:12: error: unused variable 'aborted' [-Werror,-Wunused-variable] boolean_t aborted = (scan_notif->status == IWM_SCAN_OFFLOAD_ABORTED); ^ /usr/src/sys/dev/iwm/if_iwm_scan.c:251:11: error: unused variable 'uid' [-Werror,-Wunused-variable] uint32_t uid = le32toh(notif->uid);