From owner-svn-src-head@freebsd.org Fri Oct 13 07:45:26 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52C3EE3FA82; Fri, 13 Oct 2017 07:45:26 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DAF587C0FF; Fri, 13 Oct 2017 07:45:25 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-wm0-x236.google.com with SMTP id q132so19257715wmd.2; Fri, 13 Oct 2017 00:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=zn7+OzUVGR/0au3MSGLTP9Mls9+yX1oTJHpRWt5Rkaw=; b=rodULI+76OxMwFi1Xbk9ovnvShrsWsQoe5kq3k3F+E924fa/IAUtCceOAudTv0POxZ wHgP0EgtwqKRmLfl2qDQOJCf2ABXg/T4a9vW4cg8PogKTlMGWntdYEeakVN0V6y5jl2b C4exgKVkxxjBE+6E/omKcUzGiturJPWMWDv/Pk8C3P4T7v3edI/Ma57pSP/kXqpmn/Sx P2ALF85jtxu1EHlsPWChxjdsdZpBScBnX+AEGSqyKkgCQOdqTCPSPIqDGSH/Oer5diNk 2zx3LaNeggQiY39yDCNSLeueXc3zBXQyZGoXYx0a357njogJ6pnv0EE9OFvm30/cpvzr fQPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=zn7+OzUVGR/0au3MSGLTP9Mls9+yX1oTJHpRWt5Rkaw=; b=Id4Wwtv0uuXo2Zca0G8Ly5rcO6XeP9IMvQaSKicQvPZ1edjytuySoDrU3T4XgdpR06 g0kGnEcNk5Yl/J0d2XUB604E/Hq1/VoVqQeMz23cDUS4onFj8GgQjLOSZ8MDDLrghiR8 iOhv0BAybnjqMxyvwA2GNGPWq9rjDSZSdH0nYNs/Uj/+FywZ7eplhKGITRyfezv9fVZc g+YW8eB41uAw9ZexzmNGeX4M4iOif5zJ5yIxxYnwEBAGrNSOwGIjyOEHptzijv9yTj1E Ct3t4WGBInB75/d3L8OCCm61M7mexJg9o7DV2U8MPjzV3kqqlfNT5ZeiX4NUTlXC73jV Hl+Q== X-Gm-Message-State: AMCzsaXu4t7U6JbrnMqpbKezsfsNdmbsMB+LiAVwF2w7cUTiDVhrdiPA sKa2pt0Z5UwmDOQKvUDgyfxd0NaRhLXHPrcqAX+Ylw== X-Google-Smtp-Source: AOwi7QCBox+IaU2uYQCatatZGdiULVMFdjpKGOeTJUncjdvKYjHUNF2ube3hT2EsR1arAvHOIHTbevarkfsdzVXC+MY= X-Received: by 10.223.157.141 with SMTP id p13mr606051wre.92.1507880724146; Fri, 13 Oct 2017 00:45:24 -0700 (PDT) MIME-Version: 1.0 Sender: adrian.chadd@gmail.com Received: by 10.28.86.70 with HTTP; Fri, 13 Oct 2017 00:45:23 -0700 (PDT) In-Reply-To: References: <201710130649.v9D6n7cI036282@repo.freebsd.org> From: Adrian Chadd Date: Fri, 13 Oct 2017 00:45:23 -0700 X-Google-Sender-Auth: DUnEJCUbfJCmB2sjE1jQyEnyId0 Message-ID: Subject: Re: svn commit: r324580 - head/sys/net80211 To: Hans Petter Selasky Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 07:45:26 -0000 no, it checks it. -a On 13 October 2017 at 00:11, Hans Petter Selasky wrote: > On 10/13/17 08:49, Adrian Chadd wrote: >> >> if (ieee80211_check_rxseq_amsdu_more(rxs)) { > > ^^^ does this line also need a NULL check? > > >> ni->ni_rxseqs[tid] = rxseq; >> - if (ieee80211_check_rxseq_amsdu(rxs)) >> + if ((rxs != NULL) && ieee80211_check_rxseq_amsdu(rxs)) >> IEEE80211_NODE_STAT(ni, rx_amsdu_more_end); > > > --HPS