From owner-p4-projects@FreeBSD.ORG Fri May 9 15:46:30 2003 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 1B9A037B404; Fri, 9 May 2003 15:46:30 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C7B2237B401 for ; Fri, 9 May 2003 15:46:29 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6FB1A43FBD for ; Fri, 9 May 2003 15:46:29 -0700 (PDT) (envelope-from peter@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h49MkT0U097698 for ; Fri, 9 May 2003 15:46:29 -0700 (PDT) (envelope-from peter@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h49MkSbD097695 for perforce@freebsd.org; Fri, 9 May 2003 15:46:28 -0700 (PDT) Date: Fri, 9 May 2003 15:46:28 -0700 (PDT) Message-Id: <200305092246.h49MkSbD097695@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to peter@freebsd.org using -f From: Peter Wemm To: Perforce Change Reviews Subject: PERFORCE change 30888 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2003 22:46:31 -0000 http://perforce.freebsd.org/chv.cgi?CH=30888 Change 30888 by peter@peter_hammer on 2003/05/09 15:45:40 exclude pam_ssh from the static libpam.a builds because it is such a bad citizen. it exports unprotected global variables like "int debug" which will conflict with an application. Affected files ... .. //depot/projects/hammer/lib/libpam/modules/modules.inc#5 edit .. //depot/projects/hammer/share/mk/bsd.libnames.mk#7 edit Differences ... ==== //depot/projects/hammer/lib/libpam/modules/modules.inc#5 (text+ko) ==== @@ -24,8 +24,10 @@ MODULES += pam_rootok MODULES += pam_securetty MODULES += pam_self +(!defined(NOSHARED) || ( ${NOSHARED} == "no" || ${NOSHARED} == "NO" )) .if !defined(NOCRYPT) && !defined(NO_OPENSSL) && !defined(NO_OPENSSH) && \ - !defined(NOSECURE) + !defined(NOSECURE) && !defined(NOPIC) && \ + (!defined(NOSHARED) || ( ${NOSHARED} == "no" || ${NOSHARED} == "NO" )) MODULES += pam_ssh .endif MODULES += pam_tacplus ==== //depot/projects/hammer/share/mk/bsd.libnames.mk#7 (text+ko) ==== @@ -81,7 +81,9 @@ ${LIBUTIL} ${LIBOPIE} ${LIBMD} ${LIBYPCLNT} MINUSLPAM+= -lradius -lrpcsvc -ltacplus -lcrypt \ -lutil -lopie -lmd -lypclnt -.if !defined(NOCRYPT) && !defined(NO_OPENSSL) && !defined(NO_OPENSSH) +.if !defined(NOCRYPT) && !defined(NO_OPENSSL) && !defined(NO_OPENSSH) && \ + !defined(NOPIC) && \ + (!defined(NOSHARED) || ( ${NOSHARED} == "no" || ${NOSHARED} == "NO" )) LIBPAM+= ${LIBSSH} ${LIBCRYPTO} MINUSLPAM+= -lssh -lcrypto .endif