From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Aug 29 22:21:39 2012 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 664) id AE2321065675; Wed, 29 Aug 2012 22:21:39 +0000 (UTC) Date: Wed, 29 Aug 2012 15:21:38 -0700 From: David O'Brien To: Pietro Cerutti Message-ID: <20120829222138.GA11490@dragon.NUXI.org> References: <201208291020.q7TAKETL048000@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201208291020.q7TAKETL048000@freefall.freebsd.org> X-Operating-System: FreeBSD 10.0-CURRENT X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.5.20 (2009-06-14) Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/171158: [patch] editors/vim -- remove limitation on unthreaded version of Tcl X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2012 22:21:39 -0000 Hi Pietro, > .if defined(WITH_TCL) > USE_TCL= 82+ > -USE_TCL_NO_THREADS= yes > .endif Pietro, What version of TCL did you test with? (I'm guessing 8.5). The limitation comes from r204122, which re-enabled support for Tcl versions 8.0, 8.2, 8.3, 8.4, 8.5 (after being disabled by Kris in r179352). At the time Vim was version 7.1 PL-175. We've since removed Tcl 8.0 support from ports. I'd really rather not have to test the full matrix of all the TCL versions... I wonder if this isn't what we should commit: Index: Makefile =================================================================== --- Makefile (revision 302880) +++ Makefile (working copy) @@ -90,4 +90,3 @@ MAKE_ARGS+= CONF_OPT_RUBY="--enable-ruby .if defined(WITH_TCL) -USE_TCL= 82+ -USE_TCL_NO_THREADS= yes +USE_TCL= 85+ .endif Thoughts? -- -- David