From owner-cvs-src@FreeBSD.ORG  Fri Jul 25 14:11:31 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 10B5F37B405
	for <cvs-src@FreeBSD.org>; Fri, 25 Jul 2003 14:11:31 -0700 (PDT)
Received: from mail26a.sbc-webhosting.com (mail26a.sbc-webhosting.com
	[216.173.237.164])
	by mx1.FreeBSD.org (Postfix) with SMTP id 3011F43FBD
	for <cvs-src@FreeBSD.org>; Fri, 25 Jul 2003 14:11:29 -0700 (PDT)
	(envelope-from alc@imimic.com)
Received: from www.imimic.com (64.143.12.21)0-0961157485;
	Fri, 25 Jul 2003 17:11:26 -0400 (EDT)
Sender: alc@FreeBSD.ORG
Message-ID: <3F219CFF.ECFF953D@imimic.com>
Date: Fri, 25 Jul 2003 16:11:27 -0500
From: "Alan L. Cox" <alc@imimic.com>
Organization: iMimic Networking, Inc.
X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386)
X-Accept-Language: en
MIME-Version: 1.0
To: Maxime Henrion <mux@FreeBSD.org>
References: <200307252102.h6PL2PFL063697@repoman.freebsd.org>
Content-Type: text/plain; charset=x-user-defined
Content-Transfer-Encoding: 7bit
X-Loop-Detect: 1
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm vm_contig.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Jul 2003 21:11:31 -0000

Maxime Henrion wrote:
> 
> mux         2003/07/25 14:02:25 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/vm               vm_contig.c
>   Log:
>   Add support for the M_ZERO flag to contigmalloc().
> 
>   Reviewed by:    jeff
> 
>   Revision  Changes    Path
>   1.21      +5 -1      src/sys/vm/vm_contig.c

This has a bug.  The page is not mapped at the time you perform
bzero().  (In fact, it is not mapped until after the vm_map_wire()
occurs.)  Thus, you need to use pmap_zero_page() instead.

Your tests probably succeeded because of page prezeroing.  (With
prezeroing, you never exercised the bug.)

I'm pretty sure that I sent you an e-mail about this.  If not, I
apologize.

Regards,
Alan