From owner-freebsd-current Fri Dec 4 15:56:26 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id PAA08664 for freebsd-current-outgoing; Fri, 4 Dec 1998 15:56:26 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from whistle.com (s205m131.whistle.com [207.76.205.131]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA08659 for ; Fri, 4 Dec 1998 15:56:24 -0800 (PST) (envelope-from archie@whistle.com) Received: (from smap@localhost) by whistle.com (8.7.5/8.6.12) id PAA01897; Fri, 4 Dec 1998 15:55:25 -0800 (PST) Received: from bubba.whistle.com( 207.76.205.7) by whistle.com via smap (V2.0) id xma001893; Fri, 4 Dec 98 15:55:04 -0800 Received: (from archie@localhost) by bubba.whistle.com (8.8.7/8.6.12) id PAA08863; Fri, 4 Dec 1998 15:55:04 -0800 (PST) From: Archie Cobbs Message-Id: <199812042355.PAA08863@bubba.whistle.com> Subject: Re: FreeBSD fsck updated In-Reply-To: <199812041213.XAA26965@godzilla.zeta.org.au> from Bruce Evans at "Dec 4, 98 11:13:22 pm" To: bde@zeta.org.au (Bruce Evans) Date: Fri, 4 Dec 1998 15:55:04 -0800 (PST) Cc: current@FreeBSD.ORG, julian@whistle.com, Don.Lewis@tsc.tdk.com, mckusick@McKusick.COM X-Mailer: ELM [version 2.4ME+ PL38 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Bruce Evans writes: > >+ if (fs->fs_fmod != 0) { > >+ pwarn("MODIFIED FLAG SET IN SUPERBLOCK"); > >+ if (preen) > >+ printf(" (FIXED)\n"); > >+ if (preen || reply("FIX") == 1) { > >+ fs->fs_fmod = 0; > >+ sbdirty(); > >+ } > >+ } > > ... > > Clearing fs_fmod here seems to be bogus. It is set (to 0 or 1) > unconditionally at mount time. Similarly for fs_ronly. I don't see > how it can be right to clear these flags here _only_ when a certain > type of inconsistency (that has nothing to do with these flags) > is fixed. We (Julian & me) are the ones who added this bit of code to clear the modified flag after seeing a panic caused by mounting a filesystem read-only that had this bit set (even though it was "clean", as the previous fsck didn't clear this bit). I forget exactly how it can happen, but it can (and did). -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message