From owner-freebsd-current@FreeBSD.ORG Sun Feb 3 17:11:24 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E48B16A468 for ; Sun, 3 Feb 2008 17:11:24 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.183]) by mx1.freebsd.org (Postfix) with ESMTP id C9F8313C469 for ; Sun, 3 Feb 2008 17:11:23 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so1949802waf.3 for ; Sun, 03 Feb 2008 09:11:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type; bh=vLunE2Gs8gItMHA8k7OI8afeXEqdJOY5+cFg9CVEHJU=; b=FYH5RgfO8wI9xqtTMdUqL5eYqOkMdDh25GVFHksUjpLQKtjeeU664drFSa+Vt4LpvVKxQD1DsClhSNBufA9o8P4Vx/sW/6qK8Zr10m7Bl0U27WhDbq135NaEWEh4cXBoGw/sAk1izQukCw20o4eXI/P4hKejZcnl5+mGYSievXg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type; b=bhts7nzjcwd4eGloJzRh/5IxWfX3xmc1Ux9ernkf6UnXlAHRfWu/fROJ4EomQUXh4bIOvJZQ0UYuHnhf2r2eROQHg1G+SXjNdBvEW72xKWLxNcdjAUlmJFYh8UDIMLt4Lu+PnZALiP4Bhm0+3PKsRRib4Bk7U+7O7EWhDaemzTk= Received: by 10.114.121.1 with SMTP id t1mr548876wac.67.1202058682623; Sun, 03 Feb 2008 09:11:22 -0800 (PST) Received: from kan.dnsalias.net ( [24.218.183.247]) by mx.google.com with ESMTPS id h2sm12846048rnb.16.2008.02.03.09.11.17 (version=SSLv3 cipher=OTHER); Sun, 03 Feb 2008 09:11:20 -0800 (PST) Date: Sun, 3 Feb 2008 12:11:12 -0500 From: Alexander Kabaev To: Kostik Belousov Message-ID: <20080203121112.426a8c25@kan.dnsalias.net> In-Reply-To: <20080203162918.GK57756@deviant.kiev.zoral.com.ua> References: <861w7um5o5.fsf@ds4.des.no> <20080203162918.GK57756@deviant.kiev.zoral.com.ua> X-Mailer: Claws Mail 3.0.2 (GTK+ 2.12.5; i386-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/d0pqHUKmG9oGRdDuaK0YmMI"; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: Dag-Erling Sm?rgrav , current@freebsd.org, Peter Wemm , threads@freebsd.org Subject: Re: Symbol versioning errors in libthr X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2008 17:11:24 -0000 --Sig_/d0pqHUKmG9oGRdDuaK0YmMI Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 3 Feb 2008 18:29:18 +0200 Kostik Belousov wrote: > On Sun, Feb 03, 2008 at 08:59:45AM -0700, Peter Wemm wrote: > > On Feb 3, 2008 8:16 AM, Dag-Erling Sm?rgrav wrote: > > > Here's an excerpt from the RELENG_7 vs HEAD diff of libthr's > > > symbol map: > > > > > > --- pthread.map 13 May 2007 14:12:39 -0000 1.18 > > > +++ pthread.map 20 Dec 2007 04:32:28 -0000 1.21 > > > @@ -84,9 +84,13 @@ > > > pthread_multi_np; > > > pthread_mutex_destroy; > > > pthread_mutex_getprioceiling; > > > + pthread_mutex_getspinloops_np; > > > + pthread_mutex_getyieldloops_np; > > > pthread_mutex_init; > > > pthread_mutex_lock; > > > pthread_mutex_setprioceiling; > > > + pthread_mutex_setspinloops_np; > > > + pthread_mutex_setyieldloops_np; > > > pthread_mutex_timedlock; > > > pthread_mutex_trylock; > > > pthread_mutex_unlock; > > > > > > These functions are all in FBSD_1.0, but they were introduced > > > after the branch and never MFCed, so if I understand how we've > > > implemented symbol versioning, they should be in FBSD_1.1. > > > > > > Unless someone argues credibly for keeping them in FBSD_1.0, I > > > will move them to FBSD_1.1 in a few days. > > > > > > DES > >=20 > > I'm not sure I see the point in that. Consider the > > not-moving-to-1.1 case. If somebody takes an 8.0 binary and runs > > it on 7.x, then they'll get a 'symbol not found' error. On the > > other hand, if they're moved and somebody tries the same thing, > > then they still get the same kind of 'symbol not found' error but > > with just one character different. > Additional difference is that presence of the version itself is > checked when the image is activated. This means that instead of abort > in the middle of the execution since the > rtld cannot find the symbol, the program gives error on the start.o >=20 > AFAIR, this is original (Sun) usage of the versioning, before GNU > extended it to allow individual version per symbol. This is absolutely correct description of the desired use of version names, according to both GNU and Sun. =20 > I support DES to fix this in the proposed way. Same here. --=20 Alexander Kabaev --Sig_/d0pqHUKmG9oGRdDuaK0YmMI Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iD8DBQFHpfWwQ6z1jMm+XZYRAiT3AKCEaMYe426bLPKGK0+/g/mdLP+PIwCfdQwL mr5lolibP1OyjRscuNFvOls= =8uRz -----END PGP SIGNATURE----- --Sig_/d0pqHUKmG9oGRdDuaK0YmMI--