From owner-svn-src-user@FreeBSD.ORG  Sat May 23 03:08:37 2009
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 59079106566C;
	Sat, 23 May 2009 03:08:37 +0000 (UTC)
	(envelope-from kmacy@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 4757B8FC0A;
	Sat, 23 May 2009 03:08:37 +0000 (UTC)
	(envelope-from kmacy@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n4N38b5r027154;
	Sat, 23 May 2009 03:08:37 GMT (envelope-from kmacy@svn.freebsd.org)
Received: (from kmacy@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id n4N38bOC027153;
	Sat, 23 May 2009 03:08:37 GMT (envelope-from kmacy@svn.freebsd.org)
Message-Id: <200905230308.n4N38bOC027153@svn.freebsd.org>
From: Kip Macy <kmacy@FreeBSD.org>
Date: Sat, 23 May 2009 03:08:37 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-user@freebsd.org
X-SVN-Group: user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r192620 - user/kmacy/releng_7_2_fcs/sys/dev/hwpmc
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
	src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 May 2009 03:08:37 -0000

Author: kmacy
Date: Sat May 23 03:08:36 2009
New Revision: 192620
URL: http://svn.freebsd.org/changeset/base/192620

Log:
  fix locking in loggiing loop

Modified:
  user/kmacy/releng_7_2_fcs/sys/dev/hwpmc/hwpmc_logging.c

Modified: user/kmacy/releng_7_2_fcs/sys/dev/hwpmc/hwpmc_logging.c
==============================================================================
--- user/kmacy/releng_7_2_fcs/sys/dev/hwpmc/hwpmc_logging.c	Sat May 23 02:48:15 2009	(r192619)
+++ user/kmacy/releng_7_2_fcs/sys/dev/hwpmc/hwpmc_logging.c	Sat May 23 03:08:36 2009	(r192620)
@@ -266,10 +266,8 @@ pmclog_loop(void *arg)
 	 * struct's queue.  The loop is exited when the log file
 	 * is deconfigured.
 	 */
-
-	mtx_lock_spin(&po->po_mtx);
 	for (;;) {
-
+		mtx_lock_spin(&po->po_mtx);
 		/* check if we've been asked to exit */
 		if ((po->po_flags & PMC_PO_OWNS_LOGFILE) == 0) {
 			mtx_unlock_spin(&po->po_mtx);
@@ -335,7 +333,7 @@ pmclog_loop(void *arg)
 
 		mtx_lock_spin(&pmc_bufferlist_mtx);
 		TAILQ_INSERT_HEAD(&pmc_bufferlist, lb, plb_next);
-
+		mtx_unlock_spin(&pmc_bufferlist_mtx);
 		lb = NULL;
 	}
 	mtx_lock_spin(&po->po_mtx);