Date: Tue, 7 Jul 2015 12:21:58 +0200 From: John Marino <freebsd.contact@marino.st> To: Vsevolod Stakhov <vsevolod@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r391493 - head/cad/tkgate Message-ID: <559BA846.4030506@marino.st> In-Reply-To: <559BA55C.2080701@FreeBSD.org> References: <201507070635.t676Zaqw085725@repo.freebsd.org> <559B9C36.2060300@FreeBSD.org> <559BA1B2.4050002@marino.st> <559BA55C.2080701@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/7/2015 12:09 PM, Vsevolod Stakhov wrote: > > I've checked iconv.mk and that's why I'm writing this message. It is > broken by definition. It doesn't follow the sane semantics of options > (obviously, `build` and `lib` are *NOT* mutually exclusive as they are > currently). "lib" includes "build", always. At best its redundant. However, this is out of scope for me. Open a PR on it if you feel that strongly about it. >> It means the libc iconv isn't good enough and you need the ports >> libiconv. > > Ok, so it's the new definition of 'translit' term isn't it? No it is > not! The proper name for this option should be something like 'port' > and not 'translit'. too snarky, won't respond to this. >>> Thirdly, isn't it a polite policy to send a notice to a >>> maintainer *before* committing some change to port? >> >> If the port is broken, it's broken. "Just fix it" means if somebody >> knows how to fix breakage shown on portsmon, we can do. (You're >> welcome; I did send a courtesy message seconds after this commit) > > It seems that you don't understand the word 'polite' as well. Everything I did was permissible. I did not have to send the followup message, I did that out of courtesy. I am not required to "be polite" as you define it. I feel that I was courteous and I'm sorry you don't think so. >> Weren't you getting pkg-fallout messages for FreeBSD 11? The >> problem is with the port. iconv changed on FreeBSD 11. > > I got messages from pkg-fallout but was too busy to figure out the > problem. And the problem seems to be in iconv.mk from my point of view. Even if you disagree on how iconv.mk *should be* you clearly misused it as it was. So I don't agree that it was the "problem". You had at least 4 days (probably longer) to figure it out. Isn't that enough? > Correct, I haven't mention that it was in the ports tree unless I'd > commited it. Anyway, I can see the whole history in git: > https://github.com/freebsd/freebsd-ports/commits/master/cad/tkgate/ hmm? Oh, I guess you didn't realize. Linimon had to remove the entry from MOVED: http://svnweb.freebsd.org/ports/head/MOVED?r1=390929&r2=390941
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?559BA846.4030506>