From owner-cvs-sys  Sat Nov  4 10:55:11 1995
Return-Path: owner-cvs-sys
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id KAA17104
          for cvs-sys-outgoing; Sat, 4 Nov 1995 10:55:11 -0800
Received: from aslan.cdrom.com (aslan.cdrom.com [192.216.223.142])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id KAA17093
          ; Sat, 4 Nov 1995 10:55:04 -0800
Received: from localhost.cdrom.com (localhost.cdrom.com [127.0.0.1]) by aslan.cdrom.com (8.6.12/8.6.9) with SMTP id NAA28013; Sat, 4 Nov 1995 13:21:53 -0800
Message-Id: <199511042121.NAA28013@aslan.cdrom.com>
X-Authentication-Warning: aslan.cdrom.com: Host localhost.cdrom.com didn't use HELO protocol
To: Bruce Evans <bde@zeta.org.au>
cc: bde@freefall.freebsd.org, gibbs@freefall.freebsd.org,
        CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org
Subject: Re: cvs commit: src/sys/i386/scsi aic7xxx.c aic7xxx.h 
In-reply-to: Your message of "Sun, 05 Nov 1995 05:32:27 +1100."
             <199511041832.FAA02381@godzilla.zeta.org.au> 
Date: Sat, 04 Nov 1995 13:21:53 -0800
From: "Justin T. Gibbs" <gibbs@freefall.freebsd.org>
Sender: owner-cvs-sys@FreeBSD.org
Precedence: bulk

>>>  Modified:    sys/pci   aic7870.c
>>>               sys/i386/scsi  aic7xxx.c aic7xxx.h
>>>  Log:
>>>  Fixed the type of ahcintr().  The type of an ISA interrupt handler is
>>>  incompatible with the type of a PCI interrupt handler.  A new entry
>
>>Can you back this out please?  I have the new EISA code almost ready to
>>go (later today hopefully) and it will remove this problem.  Well,
>
>No, the old version no longer compiles.

My version of the driver is very different than the one you modified,
so this just increases the number of conflicts. :(

>>actually, the eisa code expects interrupt handlers to return NULL, but
>>I expect the PCI code to lose its support for shared edge triggered
>>interrupts very soon.
>
>You may have more problems with all the other [E]ISA interrupt handlers
>that return void and are now prototyped in a central machine-generated
>file so that it is harder to vary them.
>
>Bruce

Opps, I meant they return void.  The only driver that should be using the
new EISA stuff is the aic7xxx driver, so I don't anticipate problems with
other EISA drivers until my new eisaconf stuff is reviewed, and I plunge
into converting all of the drivers doing their own EISA probes to using it.

I guess I'll have to fire off a SUP and see how you are auto-generating the
prototypes.  Why the move to a central file?

--
Justin T. Gibbs
===========================================
  Software Developer - Walnut Creek CDROM
  FreeBSD: Turning PCs into workstations
===========================================