From owner-freebsd-fs@FreeBSD.ORG Fri Apr 28 14:03:40 2006 Return-Path: X-Original-To: freebsd-fs@freebsd.org Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1716016A400 for ; Fri, 28 Apr 2006 14:03:40 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7865D43D4C for ; Fri, 28 Apr 2006 14:03:38 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id C289352C6D; Fri, 28 Apr 2006 16:03:36 +0200 (CEST) Received: from localhost (ana50.internetdsl.tpnet.pl [83.17.82.50]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 816F150B0D; Fri, 28 Apr 2006 16:03:30 +0200 (CEST) Date: Fri, 28 Apr 2006 16:02:05 +0200 From: Pawel Jakub Dawidek To: Kostik Belousov Message-ID: <20060428140205.GD864@garage.freebsd.pl> References: <20060428120855.GB1270@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oj4kGyHlBMXGt3Le" Content-Disposition: inline In-Reply-To: <20060428120855.GB1270@deviant.kiev.zoral.com.ua> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-fs@freebsd.org Subject: Re: vn_start_write(9) recursion ? X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2006 14:03:40 -0000 --oj4kGyHlBMXGt3Le Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 28, 2006 at 03:08:55PM +0300, Kostik Belousov wrote: +> vn_start_write(9) shall not be called recursively (at least, not without +> V_NOWAIT flag). Otherwise, system may deadlock if vn_write_suspend(9) +> is called between. Yes, you are right. Nice catch, actually. I hacked this patch to detect it: http://people.freebsd.org/~pjd/patches/vn_start_write_recursion.patch And it panics on boot. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --oj4kGyHlBMXGt3Le Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFEUiBdForvXbEpPzQRArhaAKC1iepGOeOKxIQi1CUZ4E94pvZ7wgCfUkJR zeDv3i7W4PvcOzhL4Lgy65Y= =DMT9 -----END PGP SIGNATURE----- --oj4kGyHlBMXGt3Le--