From owner-freebsd-arch@freebsd.org Fri Apr 27 22:19:13 2018 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CA09CFB31DE for ; Fri, 27 Apr 2018 22:19:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 6BCEF6B823 for ; Fri, 27 Apr 2018 22:19:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 2A38AFB31D9; Fri, 27 Apr 2018 22:19:13 +0000 (UTC) Delivered-To: arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 17F3AFB31D8 for ; Fri, 27 Apr 2018 22:19:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C2C5D6B807 for ; Fri, 27 Apr 2018 22:19:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id A0B9C91D9 for ; Fri, 27 Apr 2018 22:19:12 +0000 (UTC) (envelope-from jhb@freebsd.org) From: John Baldwin To: arch@freebsd.org Subject: LIBC_SCCS Date: Fri, 27 Apr 2018 15:19:06 -0700 Message-ID: <1711113.VelFtdTVS7@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 22:19:14 -0000 I suspect no one cares, but for whatever reason our current handling of the LIBC_SCCS macro in some of our libraries annoys me. In theory it seems like LIBC_SCCS's purpose is to control whether or not old SCCS IDs from Berkeley are included in libc's sources when libc is built. (Similar to how macros control the behavior of __FBSDID().) However, we use an odd construct in the tree. First, we define LIBC_SCCS by default in the CFLAGS of various libraries (libkvm, libutil, libthr, libc, etc.) which in theory would enable the IDs, but then we explicitly wrap them in #if 0, e.g.: #if defined(LIBC_SCCS) && !defined(lint) #if 0 static char sccsid[] = "@(#)kvm_hp300.c 8.1 (Berkeley) 6/4/93"; #endif #endif /* LIBC_SCCS and not lint */ I'd rather that we make LIBC_SCCS actually work by removing the #if 0 (and perhaps the lint baggage) but then remove it from the default CFLAGS to preserve the existing behavior by default. Does anyone else care if I do this? -- John Baldwin