From owner-svn-src-head@FreeBSD.ORG Mon Aug 3 09:44:11 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF6DE1065674; Mon, 3 Aug 2009 09:44:11 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe03.swip.net [212.247.154.65]) by mx1.freebsd.org (Postfix) with ESMTP id 8C1AE8FC1B; Mon, 3 Aug 2009 09:44:10 +0000 (UTC) (envelope-from hselasky@c2i.net) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=Ng6CjssoZK4A:10 a=MnI1ikcADjEx7bvsp0jZvQ==:17 a=6I5d2MoRAAAA:8 a=oTNKfSD0sQXMHyas5vEA:9 a=aG2-WZzWzLapXByvOn97HSyIWogA:4 a=SV7veod9ZcQA:10 Received: from [188.126.201.140] (account mc467741@c2i.net HELO laptop.adsl.tele2.no) by mailfe03.swip.net (CommuniGate Pro SMTP 5.2.13) with ESMTPA id 1297475629; Mon, 03 Aug 2009 11:29:08 +0200 From: Hans Petter Selasky To: Ed Schouten Date: Mon, 3 Aug 2009 11:29:04 +0200 User-Agent: KMail/1.11.4 (FreeBSD/8.0-BETA2; KDE/4.2.4; i386; ; ) References: <200908030923.12867.hselasky@c2i.net> <20090803082838.GE1292@hoeg.nl> In-Reply-To: <20090803082838.GE1292@hoeg.nl> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200908031129.06315.hselasky@c2i.net> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, Alfred Perlstein , Robert Watson , Navdeep Parhar , svn-src-head@freebsd.org Subject: Re: svn commit: r195960 - in head/sys/dev/usb: . controller input (regression patch) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2009 09:44:12 -0000 On Monday 03 August 2009 10:28:38 Ed Schouten wrote: > * Robert Watson wrote: > > I'm a bit surprised the timed key repeat in this patch would work > > properly in DDB, as microtime(9) relies on interrupts firing for > > updated timestamps. The availability of interrupts for polled input > > consumers varies, but in general this is not true (for example) at > > the DDB command prompt. Does this code work correctly when time > > stands still? > > Apart from that, who gives a *beep* about keyboard repeat while inside > the debugger. I have to confess it would be irritating to press > backspace multiple times, instead of holding the key pressed, but still, > it's not worth it. I think getmicrotime relies on interrupts, while microtime doesn't. See "man microtime". --HPS