Date: Tue, 16 Oct 2007 23:59:06 +0100 From: Ceri Davies <ceri@submonkey.net> To: Stefan Esser <se@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh Message-ID: <20071016225906.GK23043@submonkey.net> In-Reply-To: <4714F06B.7070702@FreeBSD.org> References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--rmUrFcWP4LYae1gV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Oct 16, 2007 at 07:10:03PM +0200, Stefan Esser wrote:
> Ceri Davies schrieb:
> > On Mon, Oct 15, 2007 at 10:09:19PM +0000, Stefan Esser wrote:
> >> se 2007-10-15 22:09:19 UTC
> >>
> >> FreeBSD src repository
> >>
> >> Modified files:
> >> usr.bin/locate/locate updatedb.sh=20
> >> Log:
> >> Make the updatedb script installed as /usr/libexec/locate.updatedb
> >> inspect all local file systems, not only ufs and ext2fs. A number
> >> of local file systems has been added over time, and at least zfs
> >> has the potential to become a popular choice. Without this change
> >> a ZFS root file system causes the script to ignore all file-systems
> >> and leads to an empty locate db. (An alternative is to add all the
> >> relevant file systems individually, which means that at least zfs,
> >> xfs, ntfs, ntfs-3g, msdosfs should be added, probably more).
> >=20
> > This now includes /dev, /dev/fd, /proc, /compat/linux/proc, CD-ROMs and=
DVDs
> > as well as duplicating everything in nullfs mounts, all of which are pr=
obably
> > undesirable -- well, they are undesirable to me; whether they are to
> > others is the question ;-).
>=20
> Ok, thank you for the information. I did not notice this in my tests.
>=20
> I'm not sure what the "local" pseudo fs-type is meant to be used for.
> Currently it appears to be identical to "not-remote" (which is what
> the locate db update tries to avoid, due to high network load and
> scan time).
>=20
> I plan to fix this within the next 24 hours (if anybody thinks it needs
> to be backed-out immediately, I'm willing to do this, but I'd rather
> put in the correct fix instead.
>=20
> Two possibilities: We could have another pseudo fs-type in find, which
> selects "real" file systems (and skips devfs, procfs, fdescfs, nullfs
> and probably more). Scanning of removable devices is dubious, too,
> independently of their file system. By selecting "local" and "disk
> based" file systems (which would omit not only the pseudo file-systems
> and nullfs, but also cd9660 and udf), no specific file systems needed
> to be put into the script (and find would have the knowledge).
While userland can tell if a filesystem is pseudo or not, (see lsvfs),
I'm not sure that we can reliably tell whether a device is removable or
not (cf. my camera, USB key, iPod, etc.).
> The second possibility is to extend the list in the update script. It
> needs to contain at least:
>=20
> ufs ext2fs zfs
>=20
> and probably also:
>=20
> xfs msdosfs ntfs ntfs-3g (?)
>=20
> Did I forget any?
>=20
> In fact, I'd rather enter "ufs ext2fs zfs xfs msdosfs ntfs" right now,
> instead of relying on the pseudo-fs definition in find, now that I think
> about it.
I think that's probably the best idea too.
Thanks for working on this!
Ceri
--=20
That must be wonderful! I don't understand it at all.
-- Moliere
--rmUrFcWP4LYae1gV
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)
iD8DBQFHFUI6ocfcwTS3JF8RAkwUAJ9hB2kpFOEl3BsixB6dCvmeYPGw/gCfS9OO
CoL6HbgflAq1PHDffAe2WZg=
=RP07
-----END PGP SIGNATURE-----
--rmUrFcWP4LYae1gV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071016225906.GK23043>