From owner-svn-src-head@FreeBSD.ORG Sat Nov 22 14:32:15 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 80B041065672 for ; Sat, 22 Nov 2008 14:32:15 +0000 (UTC) (envelope-from jkoshy.freebsd@gmail.com) Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.188]) by mx1.freebsd.org (Postfix) with ESMTP id C77518FC18 for ; Sat, 22 Nov 2008 14:32:14 +0000 (UTC) (envelope-from jkoshy.freebsd@gmail.com) Received: by ti-out-0910.google.com with SMTP id a1so755842tib.3 for ; Sat, 22 Nov 2008 06:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:to:cc:subject :in-reply-to:references:user-agent:mime-version:content-type:from :date:sender; bh=nqvaCnThqAVBGGx5rVWzmY+YVXjZz+99fv68pKABu4c=; b=edAZpOvHbhmy5az0nx99suppU8XrEGnIs3Grbm1b82fkEODqdS1Jeb7vN1dK0Q1dyd DKhBA6lMpg/GV5QWHx3Y4i687z2oMJMHUwEdab1t/p/lA/eW6mPpWCs0N1PCXnk5SyBm swj+aunoH+NvAbH4NZ+O9uWeJDqfFFJyfEjtc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:to:cc:subject:in-reply-to:references:user-agent :mime-version:content-type:from:date:sender; b=UTbdc2WfkDQ4rs8WSpO+35rXphN/XgxNwN9oH+F8b3EAwhhep9mSo+yO6Kreq2pPFa 0L4S6T+xmRYOFFaU8RRtNnAJw7DkNIDYHoqqqCGy5eIe9EmXzoXfU/hxJxPjrndN5qJQ K36C1EXCXg3yPYFfodXw6GG/qTAUbxg5b9/AY= Received: by 10.110.28.15 with SMTP id b15mr2257983tib.42.1227364333670; Sat, 22 Nov 2008 06:32:13 -0800 (PST) Received: from moria.unixconsulting.co.in ([117.195.162.191]) by mx.google.com with ESMTPS id w12sm5144260tib.10.2008.11.22.06.32.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 22 Nov 2008 06:32:12 -0800 (PST) Message-ID: <86hc5z7csx.wl%koshy@unixconsulting.co.in> To: Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?= In-Reply-To: <863ahlpi4q.fsf@ds4.des.no> References: <200811151111.mAFBBWnf019276@svn.freebsd.org> <863ahlpi4q.fsf@ds4.des.no> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.7 Emacs/22.1 (x86_64-pc-freebsd) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII From: Joseph Koshy Date: Sat, 22 Nov 2008 19:58:56 -0000 Sender: Joseph Koshy Cc: svn-src-head@freebsd.org, Joseph Koshy , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184994 - head/sys/dev/hwpmc X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Nov 2008 14:32:15 -0000 > Joseph Koshy writes: > > Modified: head/sys/dev/hwpmc/hwpmc_mod.c > > ============================================================================== > > --- head/sys/dev/hwpmc/hwpmc_mod.c Sat Nov 15 11:07:54 2008 (r184993) > > +++ head/sys/dev/hwpmc/hwpmc_mod.c Sat Nov 15 11:11:32 2008 (r184994) > > @@ -4656,6 +4656,9 @@ pmc_cleanup(void) > > if (md->pmd_pcpu_fini) > > md->pmd_pcpu_fini(cpu); > > } > > + > > + pmc_md_finalize(md); > > + > > free(md, M_PMC); > > md = NULL; > > pmc_restore_cpu_binding(&pb); > > This breaks the ia64, powerpc and sparc64 builds; pmc_md_finalize() is > only defined for i386 and amd64. Oh, ugh. Apologies. Should be fixed now. Koshy